Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRD] | Edit Role UI/UX updates #2592

Merged
merged 41 commits into from
Dec 5, 2024
Merged

[PRD] | Edit Role UI/UX updates #2592

merged 41 commits into from
Dec 5, 2024

Conversation

DarksightKellar
Copy link
Contributor

@DarksightKellar DarksightKellar commented Dec 4, 2024 •
edited
Loading

Closes #2526

Screenshots:
Screenshot 2024-12-04 at 15 11 31

Screenshot 2024-12-04 at 15 11 48 Screenshot 2024-12-04 at 15 12 35 Screenshot 2024-12-04 at 15 13 34

DarksightKellar and others added 30 commits December 2, 2024 15:40
@DarksightKellar
Add no payments notice + updated copy
0fe83f2
@DarksightKellar
Hide no payments notice in edit mode
ab5dacd
@DarksightKellar
Remove role edit proposal title generation
5b17b8c
@DarksightKellar
Disable roles proposal submit button if no title or description
3471bca
@DarksightKellar
Separate out invalid amount and insufficient balance validation
f5936ec
@DarksightKellar
Copy update plus bugfix
9e68841
@DarksightKellar
Fix bug causing save button to remain disable when cancelling after c…
e6cb1bd 
…licking add payment
@DarksightKellar
Fix bug -- clicking save on edit role form without removes member field
98a6eb4
@DarksightKellar
Stay on payments tab on new payment save
60a1db2
@DarksightKellar
Simplify payment detail UI
72ba2db
@DarksightKellar
Show cancel hint on desktop too + minor copy updates
66985ca
@DarksightKellar
Fix duplicate hint on desktop
05e33ea
@DarksightKellar
Fix wrong payment being selected for editing
2d6cb0b
@Da-Colon
Add SafeRolesEditFormikPageWrapper and update routing for roles editing
daea2e3
@Da-Colon
Add danger button variant with hover and active states
9c886da
@Da-Colon
remove mobile and desktop drawers
bb2c09a
@Da-Colon
Update RoleFormInfo padding for improved layout
79320fc
@Da-Colon
Update RoleTermExpiredTerms styling with background and padding adjus…
d271f92 
…tments
@Da-Colon
Update RoleFormMember styling with background color and padding adjus…
170ef1f 
…tments
@Da-Colon
Refactor payment stream components for improved structure and styling
01d5453
@Da-Colon
Enhance RoleFormInfo component styling with margin, background color,…
6014d08 
… and box shadow adjustments
@Da-Colon
Reduce top margin in RoleFormPaymentStream and RoleFormPaymentStreamT…
27a1595 
…ermed components for improved layout consistency
@Da-Colon
Add RoleDetails component and integrate into SafeRoleDetailsPage for …
4309d6c 
…enhanced role management
@DarksightKellar
copy update
51f949e
@DarksightKellar
Fix undefined wearer bug
f90f5f6
@DarksightKellar
Fix a validation and payment index bug when editing more than one pay…
bdf8404 
…ment
@DarksightKellar
Remove actions icon
28fce4b
@DarksightKellar
Hack around to center role create proposal content
e0f87ed
@DarksightKellar
Fix role create proposal input + make required
2f62ac0
@DarksightKellar
minor nudge
996538d
@netlify Netlify
Copy link

netlify bot commented Dec 4, 2024 •
edited
Loading

✅ Deploy Preview for decent-interface-dev ready!

Name Link
🔨 Latest commit 8f7259f
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/6751cb856fe02e00095137cb
😎 Deploy Preview https://deploy-preview-2592.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@parkermccurley
Copy link

Looks good! Thank you

@Da-Colon Da-Colon mentioned this pull request Dec 5, 2024
Merged
@mudrila
Merge pull request #2590 from decentdao/issue/2583-remove-roles-drawer
7b30f9c 
`[PRD | Issue #2582]` Move Role Form to own page
@mudrila
Merge pull request #2594 from decentdao/issue/2583-move-role-details-…
8f7259f 
…to-page

 `[PRD | Issue #2582]` Move Role Details to own page
@mudrila mudrila merged commit e51e012 into develop Dec 5, 2024
7 checks passed
@mudrila mudrila deleted the 2526-edit-role-updates branch December 5, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Da-Colon Da-Colon Da-Colon approved these changes

@mudrila mudrila mudrila approved these changes

@adamgall adamgall adamgall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit Role Detail view UI/UX updates
5 participants
@DarksightKellar @parkermccurley @adamgall @mudrila @Da-Colon