-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRD]
| [Issue #2545]
add more socials
#2584
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2253f5b
remove chat link from external navigation
Da-Colon f918c39
add social media URLs for Twitter, Telegram, and Discord
Da-Colon 129912f
add navigation icons for social media links in footer
Da-Colon 5fbcb55
refactor footer and external link components for improved accessibili…
Da-Colon ad6b829
fix: add missing newline at end of navigation.json file
Da-Colon 49e48f0
fix: update social media URLs for Twitter and Discord
Da-Colon 819a2b2
fix: update Telegram URL with the correct handle
Da-Colon 1758b79
Merge branch 'develop' into issue/2545-add-more-socials
Da-Colon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -105,35 +105,31 @@ export default function ExternalLink({ | |
}; | ||
|
||
return ( | ||
<Flex> | ||
<Link | ||
color={linkColor[styleVariant]} | ||
padding="0.25rem 0.75rem" | ||
<Link | ||
padding="0.25rem 0.75rem" | ||
color={linkColor[styleVariant]} | ||
gap="0.25rem" | ||
borderColor="transparent" | ||
borderWidth="1px" | ||
borderRadius="625rem" | ||
w="fit-content" | ||
_hover={isTextLink ? textLinkStyles[styleVariant].hover : pillLinkStyles[styleVariant].hover} | ||
_active={ | ||
isTextLink ? textLinkStyles[styleVariant].active : pillLinkStyles[styleVariant].active | ||
} | ||
target="_blank" | ||
rel="noreferrer" | ||
textDecoration="none" | ||
ref={internalRef} | ||
{...rest} | ||
> | ||
<Flex | ||
gap="0.25rem" | ||
borderRadius="625rem" | ||
borderColor="transparent" | ||
borderWidth="1px" | ||
_hover={ | ||
isTextLink ? textLinkStyles[styleVariant].hover : pillLinkStyles[styleVariant].hover | ||
} | ||
_active={ | ||
isTextLink ? textLinkStyles[styleVariant].active : pillLinkStyles[styleVariant].active | ||
} | ||
target="_blank" | ||
rel="noreferrer" | ||
textDecoration="none" | ||
ref={internalRef} | ||
{...rest} | ||
alignItems="center" | ||
> | ||
<Flex | ||
gap="0.25rem" | ||
mx="-0.75rem" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not really sure why this was here? The hover state's padding was being squeezed by this. |
||
alignItems="center" | ||
> | ||
{children} | ||
{isTextLink && <ArrowUpRight />} | ||
</Flex> | ||
</Link> | ||
</Flex> | ||
{children} | ||
{isTextLink && <ArrowUpRight />} | ||
</Flex> | ||
</Link> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,8 @@ | ||
export const URL_FAQ = 'https://docs.decentdao.org/app/learn-more/faq'; | ||
export const URL_CHAT = 'https://warpcast.com/~/channel/decentdao'; | ||
export const URL_WARPCAST = 'https://warpcast.com/~/channel/decentdao'; | ||
export const URL_DOCS = 'https://docs.decentdao.org/app'; | ||
export const URL_DOCS_GOV_TYPES = 'https://docs.decentdao.org/app/user-guide/types'; | ||
export const URL_DECENT = 'https://www.decentdao.org/'; | ||
export const URL_TWITTER = 'https://x.com/decentdao'; | ||
export const URL_TELEGRAM = 'https://t.me/+ZmKrTaL3pQcyOGRh'; | ||
export const URL_DISCORD = 'https://discord.gg/Zh2emKspVF'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need to wrap in a
Flex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure there was an intent for this one - could you please make sure it didn't wrecked in all the places where this component being used?