Roles payments remove duration #2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…o/fractal-interface into roles-payments-remove-duration
Base automatically changed from
issue/2230-handoff-role-details
to
roles-0.2.0/streams
August 16, 2024 20:22
Da-Colon
force-pushed
the
roles-payments-remove-duration
branch
from
6b17d2e to
0ebf33e
Compare
mudrila
approved these changes
Aug 16, 2024
src/hooks/DAO/loaders/useHatsTree.ts
Outdated
| endDate: secondsTimestampToDate(lockupLinearStream.endTime), | ||
| cliffDate: lockupLinearStream.cliff | ||
| ? secondsTimestampToDate(lockupLinearStream.cliffTime) | ||
| : undefined, | ||
| // @todo - factor in cliff date. |
There was a problem hiding this comment.
Probably can be removed after latest discussions?
src/hooks/DAO/loaders/useHatsTree.ts
Outdated
| endDate: secondsTimestampToDate(lockupLinearStream.endTime), | ||
| cliffDate: lockupLinearStream.cliff | ||
| ? secondsTimestampToDate(lockupLinearStream.cliffTime) | ||
| : undefined, | ||
| // @todo - factor in cliff date. | ||
| // @todo - handle cancelled streams |
adamgall
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
durationand all the UI and UX around it.PaymentDetailscomponent (no longer needed)Bug
There is some jankyness around the date selector.