DAO Creation Token configuration fixes

[mudrila]

• Hide token must be wrapped message until we actually resolve whether imported token is votes token or not.
• Disable token name and symbol inputs if imported token is votes token

Closes #2236
Closes #2237

[netlify]

✅ Deploy Preview for decent-interface-dev ready!

Name	Link
🔨 Latest commit	daf1ee3
🔍 Latest deploy log	https://app.netlify.com/sites/decent-interface-dev/deploys/66bcf3a2af1171000859aac2
😎 Deploy Preview	https://deploy-preview-2248.app.dev.decentdao.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[adamgall]

Yes nice

[nicolaus-sherrill]

Three things I spotted:

1. There is a bit of a delay between inputting the token address and the "wrapped" message popping up (alongside token info)
2. I'm still able to proceed to the next step to deploy the Safe, despite this message — should this be possible?
3. Bug happening when clicking on the space around the token address input field that changes my selection to "New Token"

Browser metadata

Path:      /create/erc20Token
Browser:   Chrome 127.0.0.0 on Mac OS 10.15.7
Viewport:  1465 x 904 @2x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

[nicolaus-sherrill]

Three things I spotted:

1. There is a bit of a delay between inputting the token address and the "wrapped" message popping up (alongside token info)
2. I'm still able to proceed to the next step to deploy the Safe, despite this message — should this be possible?
3. Bug happening when clicking on the space around the token address input field that changes my selection to "New Token"

Browser metadata
Open Deploy Preview · Mark as Resolved

I guess I see now after watching my recording back that we are wrapping the token. That is not clear at all that that is what is happening while in-the-flow when moving/clicking/deciding at normal behavior speeds. Big UX flag for me there.

[nicolaus-sherrill]

When inputting an address for a wrapped token, I'm given that same Wrapped message and the name now says "wrapped wrapped"

Browser metadata

Path:      /create/erc20Token
Browser:   Chrome 127.0.0.0 on Mac OS 10.15.7
Viewport:  1465 x 904 @2x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

[Da-Colon]

Looks like there is a GIthub Lint warning, but approved otherwise

[adamgall]

When inputting an address for a wrapped token, I'm given that same Wrapped message and the name now says "wrapped wrapped"

Oh that's funny, I would expect that a Wrapped token implements IVotes already (which I believe is the thing that matters when determining whether or not the given token needs to be wrapped or not), so I wonder why we'd attempt to rewrap it.

@mudrila would you mind looking into that.

[mudrila]

When inputting an address for a wrapped token, I'm given that same Wrapped message and the name now says "wrapped wrapped"

Oh that's funny, I would expect that a Wrapped token implements IVotes already (which I believe is the thing that matters when determining whether or not the given token needs to be wrapped or not), so I wonder why we'd attempt to rewrap it.

@mudrila would you mind looking into that.

@adamgall
Yup, I'll look into that
Though I think we should merge this PR and tackle that in scope of another issue, as well as other bug that @nicolaus-sherrill discovered. WDYT?

[adamgall]

The Github Lint warning on this PR doesn't make any sense lol

[adamgall]

@mudrila new issues for those items sounds good to me. Please get those created then feel free to merge this.

Thanks for your review @nicolaus-sherrill!

[adamgall]

@nicolaus-sherrill regarding

1. There is a bit of a delay between inputting the token address and the "wrapped" message popping up (alongside token info)
2. I'm still able to proceed to the next step to deploy the Safe, despite this message — should this be possible?

Yes all of this is expected.

1. Delay is because there's a network call happening there
2. The info message is not a warning or error (blocking), just informational (non blocking)

Also understood, that you call into question the UX in general.

[mudrila]

@adamgall @nicolaus-sherrill Created couple of issues - one for further development and one for design

#2253
#2252

So gonna merge this now