-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update payment columns #2241
Update payment columns #2241
Conversation
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@DarksightKellar can you please include some screenshots and descriptions of the visual changes in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xraystyle1980 |
…ls' into issue/2232-update-payment-col
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved, code wise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see the update after I create a role and the payment column is empty. That looks good.
However I want to see the pattern in action WITH a payment but I am unable to add payment to this role. See attached video
CleanShot.-.Arc.-.2024-08-15.mp4
@xraystyle1980 thanks for the bug report and video. @DarksightKellar please look into this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 minor comments, otherwise - looks good
I also changed base branch to cut off amount of changes to what's actually changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, assuming @mudrila's comments are addressed
…Move None to translations
@nicolaus-sherrill @xraystyle1980 Think I've tackled it. |
Closes #2229
Closes #2232
Replaces payments column with Active Payments and their counts
Figma:
App:
EDIT: Just realising the "no payments" look doesn't match figma. Will update.