1568 nonce page refresh
#1969
1568 nonce page refresh
#1969
Conversation
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This is a good general solution to our problem, for sure. A part of me is on the fence about whether this top-down approach is the right way, or if the approach you outlined as an alternative would be better. "General solution that might not be very efficient" vs "precision solution that won't waste network calls". |
Better as far as maybe more fine tuned say, when you open a model, or when you go to the final step to create a proposal, it makes the request so its the most up to date as possible. IMO it doesn't need to be fine tuned right now. Until we get a user saying its off or until we tackle updates to global state |
| } | ||
|
|
||
| if (prevPathname.current !== location.pathname) { | ||
| (async () => { |
There was a problem hiding this comment.
For me self-calling function makes it little bit harder to read - I'd suggest changing this to named function and then call it.
So something like async function setSafeInfo () { blah } and then setSafeInfo()
Fixes #1568
Not sure if we should also cache and/or exclude routes. but move the implementation done in the New Proposals page to the
DAOControllerand set it up to make the request whenever the url changes.The alternative to this, would be to refactor this hook back to the
isMountedref setup and add the hook to the particular pages/models/components that may create a proposal. But then we have to add it to any new pages/components that may need this features. Thoughts?