Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1942 ens chain errors #1947

Merged
merged 3 commits into from
May 30, 2024
Merged

1942 ens chain errors #1947

merged 3 commits into from
May 30, 2024

Conversation

adamgall
Copy link
Member

Closes: #1942

See: wevm/viem#781

TL;DR: simply capture the specific known and expected error, then do nothing about it. If the error isn't this ChainDoesNotSupportContract error, then we actually do want to throw it up.

@adamgall adamgall requested review from a team May 29, 2024 17:26
Copy link

netlify bot commented May 29, 2024

Deploy Preview for decent-interface-dev ready!

Name Link
🔨 Latest commit 62cb415
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/6657653a3eeda700089023d1
😎 Deploy Preview https://deploy-preview-1947.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adamgall adamgall self-assigned this May 29, 2024
Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular way you want us to test this?

@adamgall
Copy link
Member Author

@Da-Colon commect to Polygon and confirm you don't see big red errors in the console yelling about not having an ENS Registry address.

Copy link
Contributor

@DarksightKellar DarksightKellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update looks good to me, I didn't see big red blotches in my console either, so, moneh

Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet works as expected

@adamgall adamgall merged commit ade79ac into develop May 30, 2024
7 checks passed
@adamgall adamgall deleted the 1942-ens-chain-errors branch May 30, 2024 13:50
Copy link

sentry-io bot commented Jun 11, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ContractFunctionExecutionError: RPC Request failed. //home View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getEnsName not available on all chains
3 participants