-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1942 ens chain errors #1947
1942 ens chain errors #1947
Conversation
…nd fine and shouldn't result in a Sentry "uncaught exception" report
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular way you want us to test this?
@Da-Colon commect to Polygon and confirm you don't see big red errors in the console yelling about not having an ENS Registry address. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update looks good to me, I didn't see big red blotches in my console either, so, moneh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet works as expected
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Closes: #1942
See: wevm/viem#781
TL;DR: simply capture the specific known and expected error, then do nothing about it. If the error isn't this
ChainDoesNotSupportContract
error, then we actually do want to throw it up.