Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show loading message when My Safe names are loading #1918

Merged
merged 1 commit into from
May 25, 2024

Conversation

adamgall
Copy link
Member

Closes #1531

Product note:

  • Now a "Loading Safe Name" message appears while My Safe names are loading in.

Dev notes:

  • Consolidate logic in useDAOName, but need two hooks still. This one took me a while to work through, I spent too much time trying to make just one hook, but I couldn't figure it out

@adamgall adamgall requested review from a team May 24, 2024 18:53
@adamgall adamgall self-assigned this May 24, 2024
Copy link

netlify bot commented May 24, 2024

Deploy Preview for decent-interface-dev ready!

Name Link
🔨 Latest commit cd95cf2
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/6650e242b0479600090a95ba
😎 Deploy Preview https://deploy-preview-1918.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me. Tried it out and works well.

return { daoName };
};

const useGetDAONameDeferred = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second hook make sense.

@adamgall adamgall merged commit 365c844 into develop May 25, 2024
7 checks passed
@adamgall adamgall deleted the useDaoName-consolidation branch May 25, 2024 00:09
Copy link

sentry-io bot commented May 29, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ChainDoesNotSupportContract: Chain "Polygon" does not support contract "ensUniversalResolver". getDAOName(src/hooks/DAO/useGetDAOName) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor useDaoName
2 participants