Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove module proxy factory from fractal contracts and base contracts #1657

Conversation

adamgall
Copy link
Member

@adamgall adamgall commented May 6, 2024

Please review and merge #1656 first.

@adamgall adamgall self-assigned this May 6, 2024
Copy link

netlify bot commented May 6, 2024

Deploy Preview for fractal-dev ready!

Name Link
🔨 Latest commit 2f6a5ae
🔍 Latest deploy log https://app.netlify.com/sites/fractal-dev/deploys/663bd4a063858d0008aff2d0
😎 Deploy Preview https://deploy-preview-1657.app.dev.fractalframework.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adamgall adamgall force-pushed the remove-safeFactoryContract-from-useSafeContracts branch from 80b61ee to a6e24d8 Compare May 6, 2024 03:38
@adamgall adamgall force-pushed the remove-ModuleProxyFactory-from-FractalContracts-and-BaseContracts branch from 7fecc76 to 7ed9eda Compare May 6, 2024 03:39
@adamgall adamgall force-pushed the remove-safeFactoryContract-from-useSafeContracts branch from a6e24d8 to bb7c1de Compare May 6, 2024 19:11
@adamgall adamgall force-pushed the remove-ModuleProxyFactory-from-FractalContracts-and-BaseContracts branch from 7ed9eda to d99f6d3 Compare May 6, 2024 19:11
@adamgall adamgall force-pushed the remove-safeFactoryContract-from-useSafeContracts branch from bb7c1de to f7064e5 Compare May 6, 2024 19:23
@adamgall adamgall force-pushed the remove-ModuleProxyFactory-from-FractalContracts-and-BaseContracts branch 2 times, most recently from db16974 to 57a0130 Compare May 6, 2024 19:27
@adamgall adamgall force-pushed the remove-safeFactoryContract-from-useSafeContracts branch from f7064e5 to 1b8af29 Compare May 6, 2024 19:28
Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adamgall adamgall force-pushed the remove-safeFactoryContract-from-useSafeContracts branch from 1b8af29 to 11edff4 Compare May 7, 2024 17:57
@adamgall adamgall force-pushed the remove-ModuleProxyFactory-from-FractalContracts-and-BaseContracts branch from 57a0130 to c2b9f79 Compare May 7, 2024 17:57
Base automatically changed from remove-safeFactoryContract-from-useSafeContracts to develop May 7, 2024 23:20
@adamgall adamgall force-pushed the remove-ModuleProxyFactory-from-FractalContracts-and-BaseContracts branch from c2b9f79 to 650e137 Compare May 7, 2024 23:28
@adamgall adamgall changed the base branch from develop to root/remove-typechain May 8, 2024 19:37
@adamgall adamgall force-pushed the remove-ModuleProxyFactory-from-FractalContracts-and-BaseContracts branch from 650e137 to 2f6a5ae Compare May 8, 2024 19:38
@adamgall adamgall marked this pull request as ready for review May 8, 2024 19:39
@adamgall adamgall merged commit e67e6bf into root/remove-typechain May 8, 2024
7 checks passed
@adamgall adamgall deleted the remove-ModuleProxyFactory-from-FractalContracts-and-BaseContracts branch May 8, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants