-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove module proxy factory from fractal contracts and base contracts #1657
Merged
adamgall
merged 2 commits into
root/remove-typechain
from
remove-ModuleProxyFactory-from-FractalContracts-and-BaseContracts
May 8, 2024
Merged
Remove module proxy factory from fractal contracts and base contracts #1657
adamgall
merged 2 commits into
root/remove-typechain
from
remove-ModuleProxyFactory-from-FractalContracts-and-BaseContracts
May 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fractal-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamgall
force-pushed
the
remove-safeFactoryContract-from-useSafeContracts
branch
from
May 6, 2024 03:38
80b61ee
to
a6e24d8
Compare
adamgall
force-pushed
the
remove-ModuleProxyFactory-from-FractalContracts-and-BaseContracts
branch
from
May 6, 2024 03:39
7fecc76
to
7ed9eda
Compare
adamgall
force-pushed
the
remove-safeFactoryContract-from-useSafeContracts
branch
from
May 6, 2024 19:11
a6e24d8
to
bb7c1de
Compare
adamgall
force-pushed
the
remove-ModuleProxyFactory-from-FractalContracts-and-BaseContracts
branch
from
May 6, 2024 19:11
7ed9eda
to
d99f6d3
Compare
adamgall
force-pushed
the
remove-safeFactoryContract-from-useSafeContracts
branch
from
May 6, 2024 19:23
bb7c1de
to
f7064e5
Compare
adamgall
force-pushed
the
remove-ModuleProxyFactory-from-FractalContracts-and-BaseContracts
branch
2 times, most recently
from
May 6, 2024 19:27
db16974
to
57a0130
Compare
adamgall
force-pushed
the
remove-safeFactoryContract-from-useSafeContracts
branch
from
May 6, 2024 19:28
f7064e5
to
1b8af29
Compare
Da-Colon
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
adamgall
force-pushed
the
remove-safeFactoryContract-from-useSafeContracts
branch
from
May 7, 2024 17:57
1b8af29
to
11edff4
Compare
adamgall
force-pushed
the
remove-ModuleProxyFactory-from-FractalContracts-and-BaseContracts
branch
from
May 7, 2024 17:57
57a0130
to
c2b9f79
Compare
Base automatically changed from
remove-safeFactoryContract-from-useSafeContracts
to
develop
May 7, 2024 23:20
adamgall
force-pushed
the
remove-ModuleProxyFactory-from-FractalContracts-and-BaseContracts
branch
from
May 7, 2024 23:28
c2b9f79
to
650e137
Compare
DarksightKellar
approved these changes
May 8, 2024
adamgall
force-pushed
the
remove-ModuleProxyFactory-from-FractalContracts-and-BaseContracts
branch
from
May 8, 2024 19:38
650e137
to
2f6a5ae
Compare
adamgall
deleted the
remove-ModuleProxyFactory-from-FractalContracts-and-BaseContracts
branch
May 8, 2024 19:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review and merge #1656 first.