Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove safe factory contract from fractal contracts and base contracts #1655

Conversation

adamgall
Copy link
Member

@adamgall adamgall commented May 6, 2024

Please review and merge #1654 first.

@adamgall adamgall self-assigned this May 6, 2024
Copy link

netlify bot commented May 6, 2024

Deploy Preview for fractal-dev ready!

Name Link
🔨 Latest commit 8942b18
🔍 Latest deploy log https://app.netlify.com/sites/fractal-dev/deploys/663a6b8a32d4c20008478799
😎 Deploy Preview https://deploy-preview-1655.app.dev.fractalframework.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adamgall adamgall force-pushed the remove-safeFactoryContract-from-fractalContracts-and-baseContracts branch from 30f7afd to 6750007 Compare May 6, 2024 02:13
@adamgall adamgall force-pushed the remove-fractalRegistryContract-from-useSafeContracts branch from bcabb9a to dc0b926 Compare May 6, 2024 03:36
@adamgall adamgall force-pushed the remove-safeFactoryContract-from-fractalContracts-and-baseContracts branch from 6750007 to 685b860 Compare May 6, 2024 03:37
@adamgall adamgall force-pushed the remove-fractalRegistryContract-from-useSafeContracts branch from dc0b926 to 7776af5 Compare May 6, 2024 19:10
@adamgall adamgall force-pushed the remove-safeFactoryContract-from-fractalContracts-and-baseContracts branch from 685b860 to 5abcb59 Compare May 6, 2024 19:10
@adamgall adamgall force-pushed the remove-fractalRegistryContract-from-useSafeContracts branch from 7776af5 to f480adb Compare May 6, 2024 19:23
@adamgall adamgall force-pushed the remove-safeFactoryContract-from-fractalContracts-and-baseContracts branch 2 times, most recently from f2ab921 to 04708ce Compare May 6, 2024 19:28
@adamgall adamgall force-pushed the remove-fractalRegistryContract-from-useSafeContracts branch from f480adb to 7057d8b Compare May 6, 2024 19:28
Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Copy link
Contributor

@DarksightKellar DarksightKellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamgall adamgall force-pushed the remove-fractalRegistryContract-from-useSafeContracts branch from 7057d8b to e7f35a1 Compare May 7, 2024 17:57
@adamgall adamgall force-pushed the remove-safeFactoryContract-from-fractalContracts-and-baseContracts branch from 04708ce to 8942b18 Compare May 7, 2024 17:57
Base automatically changed from remove-fractalRegistryContract-from-useSafeContracts to develop May 7, 2024 23:19
@adamgall adamgall marked this pull request as ready for review May 7, 2024 23:19
@adamgall adamgall merged commit b05a7d0 into develop May 7, 2024
7 checks passed
@adamgall adamgall deleted the remove-safeFactoryContract-from-fractalContracts-and-baseContracts branch May 7, 2024 23:19
adamgall added a commit that referenced this pull request May 8, 2024
…om-fractalContracts-and-baseContracts

Remove safe factory contract from fractal contracts and base contracts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants