Remove fractal registry from fractal contracts #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fractal-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamgall
force-pushed
the
remove-fractalRegistryContract-from-BaseContracts
branch
from
4622e6d to
59c4ecc
Compare
adamgall
force-pushed
the
remove-fractalRegistry-from-FractalContracts
branch
from
1c97106 to
797170e
Compare
adamgall
force-pushed
the
remove-fractalRegistryContract-from-BaseContracts
branch
from
59c4ecc to
e5ce3aa
Compare
adamgall
force-pushed
the
remove-fractalRegistry-from-FractalContracts
branch
from
797170e to
7d3c9cc
Compare
adamgall
force-pushed
the
remove-fractalRegistryContract-from-BaseContracts
branch
from
e5ce3aa to
62fc822
Compare
adamgall
force-pushed
the
remove-fractalRegistry-from-FractalContracts
branch
2 times, most recently
from
4391fe3 to
967416c
Compare
adamgall
force-pushed
the
remove-fractalRegistryContract-from-BaseContracts
branch
from
62fc822 to
fb71f34
Compare
Da-Colon
approved these changes
May 7, 2024
| @@ -73,6 +73,7 @@ export function useMasterCopy() { | |||
| let masterCopyAddress: Address = zeroAddress; | |||
| let error; | |||
| if (baseContracts) { | |||
| // TODO after removing this moduleproxyfactorycontract from basecontracts, kill getEventRPC | |||
There was a problem hiding this comment.
It's been killed in a future PR!
| * 2. Fractal name registry name | ||
| * 3. Truncated Eth address in the form 0xbFC4...7551 | ||
| */ | ||
| export default function useDAOName({ |
There was a problem hiding this comment.
Is this doc no longer accurate?
adamgall
force-pushed
the
remove-fractalRegistryContract-from-BaseContracts
branch
from
fb71f34 to
02ed6ce
Compare
…solve all downstream issues
adamgall
force-pushed
the
remove-fractalRegistry-from-FractalContracts
branch
from
967416c to
5d38bec
Compare
Base automatically changed from
remove-fractalRegistryContract-from-BaseContracts
to
develop
May 7, 2024 23:18
adamgall
added a commit
that referenced
this pull request
May 8, 2024
…ractalContracts Remove fractal registry from fractal contracts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review and merge #1652 first.
Remove fractalRegistryContract from FractalContracts interface and resolve all downstream issues