-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make all contract addresses in NetworkConfig be Address type #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fractal-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamgall
force-pushed
the
remove-keyValuePairsContract-from-useSafeContracts
branch
from
May 6, 2024 03:34
2fa392f
to
0853951
Compare
adamgall
force-pushed
the
network-config-exports-address-types
branch
from
May 6, 2024 03:35
7082c40
to
84cb2d1
Compare
adamgall
force-pushed
the
remove-keyValuePairsContract-from-useSafeContracts
branch
from
May 6, 2024 19:05
0853951
to
188f633
Compare
adamgall
force-pushed
the
network-config-exports-address-types
branch
from
May 6, 2024 19:07
84cb2d1
to
230c68b
Compare
adamgall
force-pushed
the
remove-keyValuePairsContract-from-useSafeContracts
branch
from
May 6, 2024 19:23
188f633
to
ec3dbff
Compare
adamgall
force-pushed
the
network-config-exports-address-types
branch
2 times, most recently
from
May 6, 2024 19:28
55a87fe
to
19825b7
Compare
adamgall
force-pushed
the
remove-keyValuePairsContract-from-useSafeContracts
branch
from
May 6, 2024 19:28
ec3dbff
to
cc2061f
Compare
Da-Colon
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
DarksightKellar
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤌🏾
adamgall
force-pushed
the
remove-keyValuePairsContract-from-useSafeContracts
branch
from
May 7, 2024 17:55
cc2061f
to
34aa315
Compare
adamgall
force-pushed
the
network-config-exports-address-types
branch
from
May 7, 2024 17:55
19825b7
to
725f375
Compare
Base automatically changed from
remove-keyValuePairsContract-from-useSafeContracts
to
develop
May 7, 2024 23:18
adamgall
added a commit
that referenced
this pull request
May 8, 2024
…s-types Make all contract addresses in NetworkConfig be Address type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review and merge #1649 first.