Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all contract addresses in NetworkConfig be Address type #1651

Merged
merged 1 commit into from
May 7, 2024

Conversation

adamgall
Copy link
Member

@adamgall adamgall commented May 6, 2024

Please review and merge #1649 first.

@adamgall adamgall self-assigned this May 6, 2024
Copy link

netlify bot commented May 6, 2024

Deploy Preview for fractal-dev ready!

Name Link
🔨 Latest commit 725f375
🔍 Latest deploy log https://app.netlify.com/sites/fractal-dev/deploys/663a6b2ddeb2d00008f2920b
😎 Deploy Preview https://deploy-preview-1651.app.dev.fractalframework.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adamgall adamgall force-pushed the remove-keyValuePairsContract-from-useSafeContracts branch from 2fa392f to 0853951 Compare May 6, 2024 03:34
@adamgall adamgall force-pushed the network-config-exports-address-types branch from 7082c40 to 84cb2d1 Compare May 6, 2024 03:35
@adamgall adamgall force-pushed the remove-keyValuePairsContract-from-useSafeContracts branch from 0853951 to 188f633 Compare May 6, 2024 19:05
@adamgall adamgall force-pushed the network-config-exports-address-types branch from 84cb2d1 to 230c68b Compare May 6, 2024 19:07
@adamgall adamgall force-pushed the remove-keyValuePairsContract-from-useSafeContracts branch from 188f633 to ec3dbff Compare May 6, 2024 19:23
@adamgall adamgall force-pushed the network-config-exports-address-types branch 2 times, most recently from 55a87fe to 19825b7 Compare May 6, 2024 19:28
@adamgall adamgall force-pushed the remove-keyValuePairsContract-from-useSafeContracts branch from ec3dbff to cc2061f Compare May 6, 2024 19:28
Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

Copy link
Contributor

@DarksightKellar DarksightKellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤌🏾

@adamgall adamgall force-pushed the remove-keyValuePairsContract-from-useSafeContracts branch from cc2061f to 34aa315 Compare May 7, 2024 17:55
@adamgall adamgall force-pushed the network-config-exports-address-types branch from 19825b7 to 725f375 Compare May 7, 2024 17:55
Base automatically changed from remove-keyValuePairsContract-from-useSafeContracts to develop May 7, 2024 23:18
@adamgall adamgall marked this pull request as ready for review May 7, 2024 23:18
@adamgall adamgall merged commit c508a5e into develop May 7, 2024
7 checks passed
@adamgall adamgall deleted the network-config-exports-address-types branch May 7, 2024 23:18
adamgall added a commit that referenced this pull request May 8, 2024
…s-types

Make all contract addresses in NetworkConfig be Address type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants