Skip useDelegateVote #1641
Skip useDelegateVote #1641
Conversation
✅ Deploy Preview for fractal-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -16,7 +15,7 @@ const useDelegateVote = () => { | |||
| successCallback, | |||
| }: { | |||
| delegatee: string; | |||
| votingTokenContract: VotesERC20 | LockRelease; | |||
| votingTokenContract: LockRelease; | |||
There was a problem hiding this comment.
Can downscope the type here to just LockRelease, because we'll skip over this useDelegateVote hook completely from the DelegateModal and just call useTransaction directly.
There was a problem hiding this comment.
Took me a while to get this, but now that I do, I'm wondering what this hook is truly meant for. Specifically, why did you choose to directly use contractCallViem for votingTokenContract but use delegateVote for lockReleaseContract (in DelegateModal)?
There was a problem hiding this comment.
@DarksightKellar I also do not know why this useDelegateVote hook exists!! I plan on getting rid of it entirely when I tackle the LockRelease typechain type.
…VotesERC20 contract address, also switch to using the viem contract
adamgall
force-pushed
the
skip-usedelegatevote
branch
from
087151c to
c9d9cbe
Compare
Please review and merge #1639 first.