-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update VotesERC20Wrapper #1638
Merged
Merged
Update VotesERC20Wrapper #1638
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
7e05b91
DRY chain references in network configs
adamgall dc4c650
Change type of VotesERC20Wrapper to Address, use the address from new…
adamgall 5ea9fc1
Install new version of contracts repo alongside existing version
adamgall 6b6f46d
Add "as const" to GnosisSafeL2 abi, and therefore fix some types
adamgall 7315571
Add an ABI for VotesERC20
adamgall d942e11
Create a second useTransaction hook for these viem-style contract calls
adamgall c4518f4
Add type to declaration, not "as type" when instantiating
adamgall 78379cb
Don't need walletClient, only reading
adamgall df5fff9
I think the "wrong" type was being used on this address, but it was f…
adamgall ce17762
Add an ABI for VotesERC20Wrapper
adamgall f81960d
Remove new fractal-contracts package, that didn't work as I hoped it …
adamgall 6fdb75a
Remove votesERC20WrapperMasterCopyContract from AzoriusContracts type…
adamgall 2a4304a
Remove VotesERC20WrapperMasterCopyContract "asSigner / asProvider" ob…
adamgall 3984d1c
Fix all of the typescript errors from previous two commits
adamgall 8531ef7
Remove unnecessary reference to VotesERC20Wrapper export from 'fracta…
adamgall 8d62449
Remove VotesERC20 type, save this for another PR
adamgall 1fc3d78
Standardize local Abi import naming
adamgall 195070f
Don't need to check type any longer
adamgall 273235d
Fix Hash => Hex types
adamgall File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding
as const
here is necessary for viem's typescript support.https://viem.sh/docs/typescript#type-inference
This small change resulted in some type cleanup in the one place where this ABI was being used!