-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reskin
- home page footer
#1636
Conversation
✅ Deploy Preview for fractal-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oolala, new footer looks great!
I'm thinking it would be helpful to include copy to label the build #?
ex. Build No. cf19623
I'm not actually quite sure what that copy is supposed to be, but a label there would help.
Also the URL it is linked to goes to a 404 in Github.
@nicolaus-sherrill Broken link is kinda expected atm - it links to Lmk your thoughts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it, ship it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Can't wait to open this app up soon to see how this work yall have done!
@@ -618,3 +618,44 @@ export function DocsIllustration() { | |||
</svg> | |||
); | |||
} | |||
|
|||
export function DecentFooterLogo() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(minor). We could use createIcon
from @chakra-ui/react
. Which would allow this component to act like any other Chakra-Icon with all the bells and whistles as needed. Probably not needed in this instance but thought I'd through it out there.
Here is an example from the design repo:
https://github.com/decentdao/decent-ui/blob/develop/design/atoms/components/icons/src/AddPlus.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah in this specific case this logo will be thrown away pretty soon 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I see it in production, I think we should expand the footer on larger desktop views outside of it's current container and allow it fill the viewport entirely. This would mimic the behavior of the top nav.
Done, sir |
Closes #1634
Design: https://www.figma.com/file/9hUYtvCKjOyB92vt8ukYtD/Product-Handoff?node-id=2441-6183&mode=dev
Implementation