Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reskin | proposal input fixes #1610

Merged
merged 5 commits into from
Apr 29, 2024

Conversation

DarksightKellar
Copy link
Contributor

@DarksightKellar DarksightKellar commented Apr 29, 2024

This PR addresses a couple of UI bugs on the create proposal page:

  • clipped hover boder
  • incorrect helper text size

See this issue for extra context (+ problem screenshots)

Screenshot 2024-04-29 at 16 19 01 Screenshot 2024-04-29 at 16 19 20

For the error message design, it appears this is controlled by LabelWrapper from @decent-org/fractal-ui. See InputComponent.tsx. This will need to be handled there in that case: #1954

@DarksightKellar DarksightKellar changed the base branch from develop to reskin/refactor-root-reskin April 29, 2024 15:24
Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for fractal-dev ready!

Name Link
🔨 Latest commit d9b0397
🔍 Latest deploy log https://app.netlify.com/sites/fractal-dev/deploys/662fbb8f6102f70008210a46
😎 Deploy Preview https://deploy-preview-1610.app.dev.fractalframework.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DarksightKellar DarksightKellar linked an issue Apr 29, 2024 that may be closed by this pull request
3 tasks
Copy link
Member

@adamgall adamgall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@mudrila mudrila merged commit 7a3719f into reskin/refactor-root-reskin Apr 29, 2024
7 checks passed
@mudrila mudrila deleted the reskin/proposal-input-fixes branch April 29, 2024 18:40
@adamgall adamgall changed the title Reskin/proposal input fixes Reskin | proposal input fixes Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create proposal Input box issues
3 participants