Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reskin | Restyle proposals list #1608

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Reskin | Restyle proposals list #1608

merged 1 commit into from
Apr 26, 2024

Conversation

mudrila
Copy link
Contributor

@mudrila mudrila commented Apr 26, 2024 •
edited
Loading

  • Update breadcrumbs to match new style
  • Default style updated
  • Hover Style updated (see dev mode)
  • Badges colors no longer hardcoded, and replace new color names

Closes #1563

localhost_3000_proposals_dao=sep_0xbB4f275578d038e0D3C5A38E79dCdC0cf5b8c9Cd

@mudrila mudrila added the enhancement New feature or request label Apr 26, 2024
@mudrila mudrila self-assigned this Apr 26, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 26, 2024 •
edited
Loading

✅ Deploy Preview for fractal-dev ready!

Name Link
🔨 Latest commit 402f97e
🔍 Latest deploy log https://app.netlify.com/sites/fractal-dev/deploys/662b8f16d1600000076ca45e
😎 Deploy Preview https://deploy-preview-1608.app.dev.fractalframework.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

DarksightKellar
DarksightKellar approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@DarksightKellar DarksightKellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/components/Proposals/index.tsx
paddingLeft: '0.5rem',
paddingRight: '0.5rem',
paddingTop: '0.25rem',
paddingBottom: '0.25rem',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be collapsed into horizontal and vertical padding instead?

@adamgall adamgall linked an issue Apr 26, 2024 that may be closed by this pull request
[reskin] Update Proposal List #1563
Closed
4 tasks
@adamgall adamgall merged commit 80f2cfa into reskin/refactor-root-reskin Apr 26, 2024
7 checks passed
@adamgall adamgall mentioned this pull request Apr 26, 2024
Closed
4 tasks
@adamgall adamgall deleted the reskin/proposal-list branch April 26, 2024 20:07
@adamgall adamgall changed the title Restyle proposals list Reskin | Restyle proposals list Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarksightKellar DarksightKellar DarksightKellar approved these changes

@adamgall adamgall adamgall approved these changes

Assignees

@mudrila mudrila

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[reskin] Update Proposal List
3 participants
@mudrila @adamgall @DarksightKellar