Reskin | Update deterministic avatar generation library
#1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent with ecosystem
adamgall
requested review from
DarksightKellar,
mudrila,
tomstuart123 and
nicolaus-sherrill
✅ Deploy Preview for fractal-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamgall
commented
Apr 26, 2024
Comment on lines
19
to
20
| borderRadius={'50%'} | ||
| overflow={'hidden'} |
mudrila
approved these changes
Apr 26, 2024
| return ( | ||
| <Box | ||
| h={avatarSizes[size]} | ||
| w={avatarSizes[size]} | ||
| borderRadius={'50%'} |
There was a problem hiding this comment.
We don't need to wrap in curly braces here, it could be just borderRadius="50%"
There was a problem hiding this comment.
Fair, my autocomplete sticks those braces in. Will remove.
| return ( | ||
| <Box | ||
| h={avatarSizes[size]} | ||
| w={avatarSizes[size]} | ||
| borderRadius={'50%'} | ||
| overflow={'hidden'} |
| > | ||
| <Jazzicon address={address} /> | ||
| <img |
There was a problem hiding this comment.
Do we wanna use plan <img /> tag here? I think usually we're using <Image /> component from @chakra-ui/react
DarksightKellar
approved these changes
Apr 26, 2024
adamgall
changed the title
Reskin | Update deterministic avatar generation library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the "Jazzicon" avatars with classic "Blockie"-style avatar, to be consistent with the ecosystem.
Testing
Fractal:
Etherscan:
