Reskin | dao settings
#1606
Merged
Reskin | dao settings
#1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fractal-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mudrila
requested changes
Apr 26, 2024
src/components/pages/DaoSettings/components/ERC20TokenContainer.tsx
Outdated
Show resolved
Hide resolved
src/components/pages/DaoSettings/components/MetadataContainer.tsx
Outdated
Show resolved
Hide resolved
src/components/pages/DaoSettings/components/Signers/SignersContainer.tsx
Outdated
Show resolved
Hide resolved
src/components/pages/DaoSettings/components/Signers/modals/RemoveSignerModal.tsx
Outdated
Show resolved
Hide resolved
adamgall
approved these changes
Apr 26, 2024
mudrila
approved these changes
Apr 27, 2024
|
|
||
| export default function MetadataContainer() { | ||
| export function MetadataContainer() { | ||
| const [name, setName] = useState(''); |
There was a problem hiding this comment.
Yeah, you're right - but this name should be pre-filled with existing DAO name (unless it's shortened address). The logic of pre-filling lives in the hook few lines below. Anyway, this logic was there before so no worries
| <Button | ||
| variant="tertiary" | ||
| variant="secondary" | ||
| size="sm" | ||
| disabled={!snapshotENSValid || snapshotENS === daoSnapshotENS} |
There was a problem hiding this comment.
I've meant !snapshotENSValid || snapshotENS === daoSnapshotENS can be put into variable, but again - this logic was there so we can keep it
src/components/pages/DaoSettings/components/ModulesContainer.tsx
Outdated
Show resolved
Hide resolved
src/components/pages/DaoSettings/components/ModulesContainer.tsx
Outdated
Show resolved
Hide resolved
src/components/pages/DaoSettings/components/Signers/modals/RemoveSignerModal.tsx
Outdated
Show resolved
Hide resolved
| borderColor="neutral-3" | ||
| bg="neutral-3" | ||
| px="0.75rem" | ||
| borderRadius="625rem" |
There was a problem hiding this comment.
Just wondering - isn't borderRadius="100%" will work the same?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the settings page to match designs
Screens:
TODO: update custom nonce input