Reskin | Proposal Builder and Proposal Template builder
#1590
Conversation
mudrila
requested review from
adamgall,
DarksightKellar,
xraystyle1980,
tomstuart123,
Da-Colon,
nicolaus-sherrill and
xanaramoss
✅ Deploy Preview for fractal-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
package.json
Outdated
| @@ -5,18 +5,18 @@ | |||
| "@adraffy/ens-normalize": "^1.10.1", | |||
| "@apollo/client": "^3.7.10", | |||
| "@chakra-ui/react": "^2.8.2", | |||
| "@decent-org/fractal-ui": "^0.1.25", | |||
| "@decent-org/fractal-ui": "^0.2.5", | |||
There was a problem hiding this comment.
There's a good chance these changes are coming from me merging develop into my branch, which I have to do to pick up latest refactor into proposal builder
| borderBottomColor=" neutral-3" | ||
| /> | ||
| ); | ||
| } |
|
@mudrila Just to note: These green text buttons... ...are supposed to have a hover and active effect I'm not sure if a variant name will include this automatically. I've had to to this manually on the address copier component. |
|
I'm sorry I'm gonna merge this right now cz I CANNOT WAIT to see that shiny new Divider everywhere with the rest of the reskinned work. Argh but design needs to review too don't they. I'll control myself. Actually no any updates if any can be made in a follow up issue->PR. Better that way in fact |
|
I am ok with fast and loose merges in this reskin work lol
We can and will need to do some tweaking later, so let’s get the big swaths
of work done as quickly as possible!
…On Wed, Apr 24, 2024 at 5:44 AM Kelvin ***@***.***> wrote:
Merged #1590 <#1590>
into reskin/refactor-root-reskin.
—
Reply to this email directly, view it on GitHub
<#1590 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFMS4OTZICRFHLRDAJOHSDY655JVAVCNFSM6AAAAABGU5XVN2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGU4DSMBVHA2TKMQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Closes #1569
This PR implements visual changes to Proposal Builder https://www.figma.com/file/9hUYtvCKjOyB92vt8ukYtD/Product-Handoff?node-id=234%3A26720&mode=dev
and Proposal Template Builder https://www.figma.com/file/9hUYtvCKjOyB92vt8ukYtD/Product-Handoff?node-id=215%3A19590&mode=dev
It doesn't fully comply with design, making certain assumptions about mismatch between design and desired implementation.
Specifically, we don't need ability for user input on Proposal Builder. ABI Selector behaves the same on Proposal Builder and Template builder (as opposed to be located in different places on designs)
See attached screenshot for actual implementation
