Fix for appending templateHash query parameter
#1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o` param is first with `?` already
adamgall
requested review from
DarksightKellar,
mudrila,
tomstuart123 and
Da-Colon
✅ Deploy Preview for fractal-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Da-Colon
approved these changes
Apr 8, 2024
For the sake of getting this hotfix pushed, going to assume @tomstuart123 's approval based on this comment he left on Slack. |
mudrila
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All new query params should now be appended with
&, because thedaoparam is first with?alreadyCloses #1526