Use ProposalBuilder on Create Proposal page #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
…ot specified - immediately return transaction with calldata set to 0x
Da-Colon
approved these changes
Apr 9, 2024
Comment on lines
20
to
22
| isValidUrl(parameter.value!.trim()) | ||
| ? encodeURIComponent(parameter.value!.trim()) // If parameter.value is valid URL with special symbols like ":" or "?" - decoding might fail, thus we need to encode URL | ||
| : parameter.value!.trim(), |
There was a problem hiding this comment.
O interesting. good edge case catch.
DarksightKellar
approved these changes
Apr 9, 2024
…that-just-sends-assets Allow creating proposal with no function name / signature specified
mudrila
merged commit c2b60ee
into
feature/#1363-generic-templates-builder
3 checks passed
mudrila
deleted the
feature/#1363-use-proposal-builder-for-create-proposal-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completely removes
CreateProposalcomponents and leveragesProposalBuilderon "Create Proposal" page. This is interim PR that doesn't target final "clean" state but rather accumulates bunch of deletes ofCreateProposalcomponents and adjustsProposalBuilderto have better UI inproposalcreation mode.Depends on #1529