Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix freeze button state bug #1518

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

DarksightKellar
Copy link
Contributor

@DarksightKellar DarksightKellar commented Apr 5, 2024

Closes #1508

This PR fixes a bug preventing the freeze button on a freeze proposal from updating itself when the connected wallet acount changes.

Testing

  • Make sure to be on a parent DAO with more than one signer
  • On a sub-DAO (also with more than one signer), initiate a freeze
  • Change account to a signer on the DAO. The button should update itself in time, after which the user can execute their vote.

Notes

  • The behaviour of a permutation of signers on the parent and child DAOs where signers on the parent are not necessarily on the child and vice versa is untested
  • The parent dao should have at least as many signers as the child dao requires to execute a proposal. If fewer, the freeze proposal can never get executed
  • Even if the parent dao requires more than one signer, if the child dao requires just one, initiated freezes are immediately executed.

Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for fractal-dev ready!

Name Link
🔨 Latest commit a1612b7
🔍 Latest deploy log https://app.netlify.com/sites/fractal-dev/deploys/660fdbf3869d990008edf776
😎 Deploy Preview https://deploy-preview-1518.app.dev.fractalframework.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

Copy link
Member

@adamgall adamgall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM no comments works as expected thanks @DarksightKellar

@DarksightKellar DarksightKellar merged commit b1a0de1 into develop Apr 5, 2024
7 checks passed
@DarksightKellar DarksightKellar deleted the bug/freeze-dao-state-update branch April 5, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switching Account doesn't update Freeze Vote UI
3 participants