[Maintenance] Investigate extra requests useERC20Claim
#1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Da-Colon
changed the title
useERC20Claim
Da-Colon
commented
Mar 26, 2024
There was a problem hiding this comment.
Most DAOs won't have a ERC20Claim contract. (assumingly). Maybe we need a better way to check for claiming contract?
But for now. It did not have anything preventing it from reattempting the requests as the app's initial render settles. This update adds a loadkey to prevent additional loads.
adamgall
approved these changes
Mar 26, 2024
mudrila
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched from #1486
Investigate Additional Requests in
useERC20ClaimhookMultiple re-renders was causing this to run this request more than once. Added a conditional to only allow this to fire once.
Closes #1456