Update Proposal list #1472

Da-Colon · 2024-03-20T04:19:44Z

Updated Proposal List (Dashboard, Proposals (Governance page), and updates Badge on Details

Testing:

For testing: Please view Dashboard, Proposals Page and Details of a few different DAO types. Make sure everything loads correctly. Here is the design link to compare. https://www.figma.com/file/dNWxEnscUonneTsNdzn6qZ/Components---Fractal-Design-System-0.0.1?type=design&node-id=10810-261&mode=design&t=qBGWJaHrBkbPIkTo-0

Here are some different DAO addresses:
0x259a5770d7242b5aBa7420926690E90c69037d10
0x70484d88cB248b9a5150d133fEDBa7948AfC9b0B
0xDD73b64C8845868CCddB30df83929fBA63b4d284
0x76DA0508ee8f900be06E58D8D56F418494C266d7

Screenshots:

Token DAO

Multisig DAO

Snapshot Proposals

Note here. Proposal Description format is handled by the Markdown. I removed a conditional that was doing plaintext when truncated to let the markdown do its thing. Its more or less controlled by number of lines now.

Responsive Design

Details Page update (Badge | Proposal Title | Proposal Description)

Closes #1448

netlify · 2024-03-20T04:20:00Z

✅ Deploy Preview for fractal-dev ready!

Name	Link
🔨 Latest commit	`78aa6e4`
🔍 Latest deploy log	https://app.netlify.com/sites/fractal-dev/deploys/6601fe343dba4d00086a2cbc
😎 Deploy Preview	https://deploy-preview-1472.app.dev.fractalframework.xyz
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Da-Colon · 2024-03-20T04:25:14Z

src/components/Proposals/ProposalCard/ProposalCard.tsx

Main entry to changes. Replaces current ActivityGovernance component.

Da-Colon · 2024-03-20T04:27:24Z

src/components/ui/badges/Badge.tsx

+const greenPlus2 = '#56A355';
+const greenMinus5 = '#0A320A';
+const greenHover = '#0E440E';
+
+const redPlus4 = '#FFC7C7';
+const redMinus2 = '#640E0D';
+const redHover = '#76110F';
+
+const sandBG = '#C18D5A';
+const sandHover = '#B97F46'
+const blackText = '#150D04'
+
+const grayBG = '#9A979D'
+const grayHover = '#8C8990'
+
+const lightBlueBG = '#A3B9EC'
+const lightBlueHover = '#8DA8E7'
+const darkBlueText = '#0A1E3D'
+
+const darkBlueBG = '#1B3B83'
+const darkBlueHover = '#17326E'
+const lightBlueText = '#D1DCF5'


New colors are hardcoded in file for now. Not ideal I tried to use the name given in the figma file but some don't have colors yet. This can be move to design system once overhaul is done.

Da-Colon · 2024-03-20T04:28:38Z

src/components/ui/badges/QuorumBadge.tsx

uses meetsQuorum to pull the information directly from contract for linearERC20 strategy token DAOs. I created a issue for update ERC721 contract to do the same.

Da-Colon · 2024-03-20T04:29:42Z

src/components/ui/proposal/Markdown.tsx

-  if (truncate) {
-    return (
-      <Text
-        noOfLines={2}
-        fontWeight={400}
-        minWidth="100%"
-      >
-        {plainText}
-      </Text>
-    );
-  }


I don't think we need this. Markdown looks pretty good. going straight to the markdown below. Let me know @mudrila if this is a bad idea.

Yeah the idea was to remove styling applied by markdown in order to fit more actual content. I don't have strong opinion here but think we'd need some additional input to decide

Da-Colon · 2024-03-20T04:30:26Z

src/i18n/locales/uk/common.json

Are we still removing translations if the english json is updated?

Da-Colon · 2024-03-20T05:02:26Z

Here is the current UI when Frozen. @xraystyle1980 @nicolaus-sherrill @xanaramoss

There are few 'Activities' that have UI components but I haven't seen them in the UI in a while. This Frozen Activity is one of them. This PR doesn't touch the UI for these activities beyond the shared components (Badge, Proposal Title).

nicolaus-sherrill

So far, I'm only able to find Executed, Rejected,and Closed in my testing but I'm seeing issues with color and vertical alignment on them.

See images below:

Da-Colon · 2024-03-20T17:32:58Z

So far, I'm only able to find Executed, Rejected,and Closed in my testing but I'm seeing issues with color and vertical alignment on them.

See images below:

@nicolaus-sherrill Coolio. updated colors and fixed alignment (which was a little tricky)

mudrila

Couple minor suggestions, but other than that - looks good!

src/components/Proposals/ProposalCard/ProposalCard.tsx

mudrila · 2024-03-21T11:27:12Z

src/components/ui/badges/QuorumBadge.tsx

+
+  // @dev only azorius governance has quorum
+  if ((proposal as SnapshotProposal).snapshotProposalId || !votingStrategy) {
+    return null;


Snapshot proposal also might have a quorum, yet it might be non-trivial to calculate it. Can you create a ticket so we'd investigate this?

src/components/ui/badges/QuorumBadge.tsx

mudrila · 2024-03-21T11:29:21Z

src/components/ui/proposal/Markdown.tsx

-  if (truncate) {
-    return (
-      <Text
-        noOfLines={2}
-        fontWeight={400}
-        minWidth="100%"
-      >
-        {plainText}
-      </Text>
-    );
-  }


Yeah the idea was to remove styling applied by markdown in order to fit more actual content. I don't have strong opinion here but think we'd need some additional input to decide

- ProposalCountdown updated for compadability

- removes other translation

xraystyle1980 · 2024-03-22T16:49:24Z

The spacing is off. All status badges should have 8px horizontal padding, 8px gap between icon and label, and 4px border radius. (the colors are not 100% but we have new colors coming soon so I'm not pushing back on that)

Da-Colon · 2024-03-22T17:19:48Z

@xraystyle1980 Colors are wrong? I'll take a look? I'll take another look at the padding as well.

Da-Colon · 2024-03-25T13:40:47Z

@xraystyle1980 Ah I see ha. There were a few updates to the colors I didn't notice and didn't realize there was a hover text color. Ive updated the badge. I've adjusted the padding around the badge to 8px to match the designs more closely.

tomstuart123 · 2024-03-25T15:49:31Z

@Da-Colon

Two line proposal title's force the proposer address to the wrong line

see below proposal 14 (i.e. address below title) v.s proposal 13 where the address is on the same line

nicolaus-sherrill · 2024-03-25T18:07:49Z

@Da-Colon

Two line proposal title's force the proposer address to the wrong line

see below proposal 14 (i.e. address below title) v.s proposal 13 where the address is on the same line

My take is that keeping proposal titles to one line, and implementing some visual way to represent that there is more of the title would be best.

However, if that's not reasonable/feasible, definitely want to see that author name on the same line as the proposal title.

src/components/ui/proposal/Markdown.tsx

src/components/ui/badges/QuorumBadge.tsx

src/components/ui/badges/Badge.tsx

…igns

Da-Colon · 2024-03-25T19:05:15Z

@Da-Colon
Two line proposal title's force the proposer address to the wrong line
see below proposal 14 (i.e. address below title) v.s proposal 13 where the address is on the same line

My take is that keeping proposal titles to one line, and implementing some visual way to represent that there is more of the title would be best.

However, if that's not reasonable/feasible, definitely want to see that author name on the same line as the proposal title.

Yeah I actually ran into quite a bit of an issue getting these to play together with longer titles. Almost all the Proposals are fine except for the longer ones.

xraystyle1980 · 2024-03-26T14:30:47Z

Layout looks good @Da-Colon

nicolaus-sherrill

Thanks for making those pixel-perfect tweaks. Looks great!

Da-Colon self-assigned this Mar 20, 2024

Da-Colon commented Mar 20, 2024

View reviewed changes

Da-Colon requested review from adamgall, xraystyle1980, mudrila, tomstuart123, nicolaus-sherrill and xanaramoss March 20, 2024 14:07

Da-Colon marked this pull request as ready for review March 20, 2024 14:07

nicolaus-sherrill requested changes Mar 20, 2024

View reviewed changes

Da-Colon requested a review from nicolaus-sherrill March 20, 2024 17:39

mudrila requested changes Mar 21, 2024

View reviewed changes

Da-Colon mentioned this pull request Mar 21, 2024

Snapshot Proposal Quorum #1477

Closed

Da-Colon requested a review from mudrila March 21, 2024 14:05

mudrila approved these changes Mar 21, 2024

View reviewed changes

Da-Colon added 12 commits March 21, 2024 14:30

update Badge component with updated designs

d2c3ff8

- ProposalCountdown updated for compadability

create badge to display quorum

f0e2538

update badge to use meetQuroum for linearERC20Strategy

910092c

update hover colors for timelock and frozen badges

976ae20

update Activity/Proposal description and title to updated designs

04c06ec

add author to Description

19eaac2

- removes other translation

Replace ActivityGovernance with Updated ProposalCard

f2df8cc

replace ActivityGovernance with ProposalCard

680a38e

update to lastest badge colors

4e2c15e

remove unused file

4e2941c

remove comments

4fe5fa3

run lint/pretty

8e873f1

Da-Colon added 4 commits March 21, 2024 14:30

fix badge colors

b496ced

fix alignment

574fbc8

pretty/lint run

3bd3ecc

remove fragment

7eff319

Da-Colon force-pushed the design-update/proposal-list branch from 401d3b6 to 7eff319 Compare March 25, 2024 13:21

Da-Colon added 2 commits March 25, 2024 09:35

update colors to match figma

b728ea0

adjust padding

36f73db

adamgall requested changes Mar 25, 2024

View reviewed changes

src/components/ui/proposal/Markdown.tsx Show resolved Hide resolved

src/components/ui/badges/QuorumBadge.tsx Outdated Show resolved Hide resolved

src/components/ui/badges/Badge.tsx Outdated Show resolved Hide resolved

Da-Colon added 5 commits March 25, 2024 14:51

clean up logic around description and title to more closely match des…

3b0d3a6

…igns

remove comment

72690ec

switch back to previous way to calc quorum

f40fa6a

run pretty/lint

bdb272e

remove unused package

533cf46

Da-Colon requested a review from adamgall March 25, 2024 19:08

Da-Colon added 2 commits March 25, 2024 15:20

remove ugly hardcoded values

c51a58a

update markdown css with maxWidth 0 to allow content to shrink

6e8507e

adamgall approved these changes Mar 25, 2024

View reviewed changes

Da-Colon added 2 commits March 25, 2024 15:31

run pretty/lint

2886d03

revent author on details screen

78aa6e4

nicolaus-sherrill approved these changes Mar 26, 2024

View reviewed changes

Da-Colon merged commit 54a9e51 into develop Mar 26, 2024
7 checks passed

Da-Colon deleted the design-update/proposal-list branch March 26, 2024 15:34

adamgall mentioned this pull request Apr 5, 2024

Release/2024-04-08 Part 1: The Merge into prod #1521

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Proposal list #1472

Update Proposal list #1472

Da-Colon commented Mar 20, 2024 •

edited

Loading

netlify bot commented Mar 20, 2024 •

edited

Loading

Da-Colon Mar 20, 2024

Da-Colon Mar 20, 2024

Da-Colon Mar 20, 2024

Da-Colon Mar 20, 2024

mudrila Mar 21, 2024

Da-Colon Mar 20, 2024

Da-Colon commented Mar 20, 2024 •

edited

Loading

nicolaus-sherrill left a comment

Da-Colon commented Mar 20, 2024

mudrila left a comment

mudrila Mar 21, 2024

Da-Colon Mar 21, 2024

mudrila Mar 21, 2024

xraystyle1980 commented Mar 22, 2024 •

edited

Loading

Da-Colon commented Mar 22, 2024

Da-Colon commented Mar 25, 2024

tomstuart123 commented Mar 25, 2024

nicolaus-sherrill commented Mar 25, 2024

Da-Colon commented Mar 25, 2024

xraystyle1980 commented Mar 26, 2024

nicolaus-sherrill left a comment

Update Proposal list #1472

Update Proposal list #1472

Conversation

Da-Colon commented Mar 20, 2024 • edited Loading

Testing:

Screenshots:

Token DAO

Multisig DAO

Snapshot Proposals

Responsive Design

Details Page update (Badge | Proposal Title | Proposal Description)

netlify bot commented Mar 20, 2024 • edited Loading

✅ Deploy Preview for fractal-dev ready!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Da-Colon commented Mar 20, 2024 • edited Loading

nicolaus-sherrill left a comment

Choose a reason for hiding this comment

Da-Colon commented Mar 20, 2024

mudrila left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xraystyle1980 commented Mar 22, 2024 • edited Loading

Da-Colon commented Mar 22, 2024

Da-Colon commented Mar 25, 2024

tomstuart123 commented Mar 25, 2024

nicolaus-sherrill commented Mar 25, 2024

Da-Colon commented Mar 25, 2024

xraystyle1980 commented Mar 26, 2024

nicolaus-sherrill left a comment

Choose a reason for hiding this comment

Da-Colon commented Mar 20, 2024 •

edited

Loading

netlify bot commented Mar 20, 2024 •

edited

Loading

Da-Colon commented Mar 20, 2024 •

edited

Loading

xraystyle1980 commented Mar 22, 2024 •

edited

Loading