Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Background Glow #1438

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Conversation

Da-Colon
Copy link
Contributor

@Da-Colon Da-Colon commented Mar 12, 2024

This PR updates the decent UI version. This version removes the background gold glow

Screenshot

localhost_3000_(Desktop)

Closes #1424

- removes background gold glow
@Da-Colon Da-Colon added the enhancement New feature or request label Mar 12, 2024
@Da-Colon Da-Colon self-assigned this Mar 12, 2024
Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for fractal-framework-dev ready!

Name Link
🔨 Latest commit 385e670
🔍 Latest deploy log https://app.netlify.com/sites/fractal-framework-dev/deploys/65f1b3cf225e320008f04065
😎 Deploy Preview https://deploy-preview-1438.app.dev.fractalframework.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@adamgall adamgall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, shipit

@xraystyle1980
Copy link

xraystyle1980 commented Mar 13, 2024

Can you make the background a solid color? #262521 (#262521 should be the same as chocolate 700 in the current color palette)
And take a look at the bottom of the page when you scroll down, the background did not stretch the whole screen.
CleanShot - Arc - 2024-03-13@2x
(Chromium/Arc browser)

Copy link
Member

@adamgall adamgall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DON'T SHIPIT!

- update to new release
@adamgall adamgall self-requested a review March 13, 2024 14:14
Copy link
Member

@adamgall adamgall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better now, SHIPIT

@Da-Colon Da-Colon merged commit 4d00423 into develop Mar 13, 2024
7 checks passed
@Da-Colon Da-Colon deleted the design-request/remove-background-glow branch March 13, 2024 14:18
This was referenced Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eliminate the yellow radial gradient background from existence
4 participants