Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Multisig Deployment Fix #1435

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

Da-Colon
Copy link
Contributor

Closes #1433

An extra conditional was preventing deployment of new multisig DAOs.

@Da-Colon Da-Colon added the bug Something isn't working label Mar 12, 2024
@Da-Colon Da-Colon requested review from adamgall and mudrila March 12, 2024 15:24
@Da-Colon Da-Colon self-assigned this Mar 12, 2024
Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for fractal-framework-dev ready!

Name Link
🔨 Latest commit 7511dd6
🔍 Latest deploy log https://app.netlify.com/sites/fractal-framework-dev/deploys/65f073c4ad25d10007674b43
😎 Deploy Preview https://deploy-preview-1435.app.dev.fractalframework.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@adamgall adamgall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks like this code was (likely, accidentally) changed a few PRs ago:

https://github.com/decent-dao/fractal-interface/pull/1417/files#diff-4ebd41ab53e8aa3008db0c87c59eb6bf112a2685dd413e06cd81a336d5237e43R88-R94

@mudrila do you confirm that this change was unintentional?

@adamgall adamgall merged commit fcfd27b into develop Mar 12, 2024
7 checks passed
@adamgall adamgall deleted the bugfix/1433-multisig-deployment-bug branch March 12, 2024 19:46
This was referenced Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploying Multisig DAO isn't working
3 participants