Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Production push #1420

Merged
merged 70 commits into from
Mar 8, 2024
Merged

Production push #1420

merged 70 commits into from
Mar 8, 2024

Conversation

adamgall
Copy link
Member

@adamgall adamgall commented Mar 7, 2024

mudrila and others added 30 commits February 28, 2024 00:56
@mudrila
Implement fetching coin prices from CoinGecko
0b03759
@mudrila
Leverage useFormatCoins for showing treasury total on DAO dashboard page
2942280
@adamgall
empty commit
22b4d13
@adamgall
Merge branch 'develop' into fix/show-token-prices
324edbe
@adamgall
Merge branch 'release-v0.1.8' into develop
2cd70e5
@adamgall
The ProposalActions buttons, which show up in Proposal list cards, no…
3bc074c 
… longer needs to be a link
@mudrila
Add Netlify function tokenPrices, route request to CoinGecko, cache t…
e1f77e1 
…oken prices through Netlify blob
@mudrila
Refactor and cleanup of storing/getting prices
2d6de29
@mudrila
Fix returningprice for ETH
ea7aa8f
@mudrila
Try fixing token fiat balance overflow
c5b477a
@mudrila
Use ethers.constants.MaxUint256 instead of Number max value
88f356a
@mudrila
Use smaller multiplicator
3e5f170
@mudrila
Add math.round
59dd067
@mudrila
Merge branch 'develop' into fix/show-token-prices
e5afb36
@adamgall
Merge pull request #1397 from decent-dao/bug/#1396-nested-anchor-tags
78cf343 
Fix Nested Anchor Tags
@adamgall
Delete the RELEASES.md doc, it's not relevant any longer
969f712
@adamgall
Remove windows specific scripts from package.json
b7ef35f
@adamgall
set:env script wasn't working, so inlined into dev, start, start:https
4f19bf3
@adamgall
Use the git shorthash as version identifier in Footer
8926efb
@adamgall
Remove version property from package.json
2befe63
@adamgall
Remove GENERATE_SOURCEMAP=false from some npm scripts
49d744b
@adamgall
Remove the start and start:https scripts
a7b7890
@adamgall
Build the graphql client when npm run dev
0f31fd6
@mudrila
Rename netlify function, fix returning response error, better typing …
6781722 
…within netlify function
@mudrila
Handle better CoinGecko requesting error and return cached prices
8633535
@mudrila
Show cached prices on FE if request to CoinGecko failed
a3783d4
@adamgall
Add start and start:https scripts back
effde42
@adamgall
Remove unused import
e22463e
@adamgall
Delete unnecessary commands from start scripts
d25dead
@adamgall
temp - remove start scripts
8ad9700
adamgall and others added 10 commits March 7, 2024 15:45
@adamgall
Convert minutes to seconds, specify in variable names that we're deal…
2f85687 
…ing with seconds
@adamgall
Merge pull request #1416 from decent-dao/prettier-eslint-cleanup
11303a7 
Prettier eslint cleanup
@adamgall
Merge commit '11303a767df67e67e8007ca20e07894b268e3269' into fix/show…
7720d94 
…-token-prices
@adamgall
Prettier updates
daf34df
@adamgall
Merge commit '11303a767df67e67e8007ca20e07894b268e3269' into refactor…
c3dd1c9 
…/ethers-provider-and-signer
@adamgall
Pretty fix
ed46ee2
@adamgall
Merge pull request #1382 from decent-dao/fix/show-token-prices
d4b6591 
Show token prices
@adamgall
Merge pull request #1417 from decent-dao/refactor/ethers-provider-and…
16d38f1 
…-signer

Refactor/ethers provider and signer
@adamgall
Merge commit '16d38f15ff41f0c12548071bb5415cb4a5734e59' into sentry-u…
17743aa 
…pdates
@adamgall
Merge pull request #1418 from decent-dao/sentry-updates
73410e8 
Sentry updates
@netlify Netlify
Copy link

netlify bot commented Mar 7, 2024 •
edited
Loading

✅ Deploy Preview for fractal-framework-dev ready!

Name Link
🔨 Latest commit 73410e8
🔍 Latest deploy log https://app.netlify.com/sites/fractal-framework-dev/deploys/65ea3f3b03bc1b00081d9edc
😎 Deploy Preview https://deploy-preview-1420.app.dev.fractalframework.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Mar 7, 2024 •
edited
Loading

✅ Deploy Preview for fractal-framework ready!

Name Link
🔨 Latest commit 73410e8
🔍 Latest deploy log https://app.netlify.com/sites/fractal-framework/deploys/65ea3f3b9b64bc000852599a
😎 Deploy Preview https://deploy-preview-1420.app.fractalframework.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adamgall adamgall requested a review from parkermccurley March 7, 2024 22:31
azadikoff
azadikoff approved these changes Mar 7, 2024
View reviewed changes
Copy link

@azadikoff azadikoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too sure what to look for, but I poked around the site and didn't find any issues.

nicolaus-sherrill
nicolaus-sherrill reviewed Mar 8, 2024
View reviewed changes
Copy link

@nicolaus-sherrill nicolaus-sherrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Token prices are not showing up in Decent DAO's treasury. Treasury balance is showing $0 and all tokens in the treasury show a $0 value.

Testing:
Firefox on MacOS Sonoma.

@mudrila
Copy link
Contributor

mudrila commented Mar 8, 2024

Token prices are not showing up in Decent DAO's treasury. Treasury balance is showing $0 and all tokens in the treasury show a $0 value.

@nicolaus-sherrill Have you connected your wallet? If so - you also need to switch your wallet into mainnet, otherwise app defaults too Sepolia for app.dev

@adamgall
Copy link
Member Author

adamgall commented Mar 8, 2024

@nicolaus-sherrill thanks for the comments!

as @mudrila said, please share some more details:

  • what is the exact URL you're looking at?
    • this should include the specific Safe
  • do you have a wallet connected and is that wallet on the intended network?

@nicolaus-sherrill
Copy link

@adamgall @mudrila

Here is a screenshot showing what I'm seeing. Wallet is connected and on Mainnet.

URL:Decent DAO Treasury

Screenshot 2024-03-08 at 11 07 28 AM

@adamgall
Copy link
Member Author

adamgall commented Mar 8, 2024 •
edited
Loading

@nicolaus-sherrill You're on the production URL, which doesn't include the changes that we're proposing in this PR. The idea is that we'd like to get this code into production, but it's not there yet.

Use the "Deploy Preview" link from the Netlify comment above, to access a URL that includes the changes within this Pull Request.

@nicolaus-sherrill nicolaus-sherrill self-requested a review March 8, 2024 17:20
Da-Colon
Da-Colon approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@adamgall adamgall merged commit 251a91e into main Mar 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaus-sherrill nicolaus-sherrill nicolaus-sherrill approved these changes

@Da-Colon Da-Colon Da-Colon approved these changes

@mudrila mudrila mudrila approved these changes

@azadikoff azadikoff azadikoff approved these changes

@xraystyle1980 xraystyle1980 Awaiting requested review from xraystyle1980

@tomstuart123 tomstuart123 Awaiting requested review from tomstuart123

@parkermccurley parkermccurley Awaiting requested review from parkermccurley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adamgall @mudrila @nicolaus-sherrill @azadikoff @Da-Colon