[BUGFIX] Stale WalletConnect Session

[Da-Colon]

Description

Looking into MPCVault Wallet Connections, I noticed than after disconnecting from Wallets connected via WalletConnect. I am unable to reopen the wallet connect menu and the Console shows errors related to the session key not matching and then showing core/relayer errors.

After looking at the setup. It appears that what is happening is that for some reason after clicking disconnect that the menu closes and causes the func to end before updating local storage that the session has ended. This causes WAGMI and Walletconnect to desync.

Adding a small delay (setTimeout) after execution of disconnect fixes this issue.

Instead of using AppState to determine connection status, as this seems to be updated quicker than wagmi's state. switching out to use useWalletClient to determine connection status seems to be a better fix.

Testing

First see the error on dev:

• Connect any wallet via WalletConnect and disconnect.
• Reopen Connect Modal and Select Wallet Connect again. Should do nothing.

On deploy preview do the same thing and you should notice that you are able to click into the WalletConnect QR code again. (You may need to refresh browser after testing the error)

[netlify]

✅ Deploy Preview for fractal-framework-dev ready!

Name	Link
🔨 Latest commit	9886b81
🔍 Latest deploy log	https://app.netlify.com/sites/fractal-framework-dev/deploys/65e628ec3ebfbb000814e7f0
😎 Deploy Preview	https://deploy-preview-1406.app.dev.fractalframework.xyz
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[adamgall]

I wouldn't think that this code actually delays anything from happening... the onClick handler is synchronous and so execution won't wait for the timer to complete.

[Da-Colon]

I wouldn't think that this code actually delays anything from happening... the onClick handler is synchronous and so execution won't wait for the timer to complete.

@adamgall . Yeah it was for delaying the function from finishing. But this delay wasn't fixing the problem. I just edited the PR description and pushed a new commit but.

Instead of using AppState to determine connection status, as this seems to be updated quicker than wagmi's state. switching out to use useWalletClient to determine connection status seems to be a better fix.

[adamgall]

@Da-Colon can you please open an issue for this PR, add it to the new Fractal project (yeah yeah i know, going back to just a single project board), and fill in the appropriate custom data?

[Da-Colon]

@adamgall no worries can do. can you link the project to fractal-interface repo for easy access whenever you get a chance nvm I did it

[adamgall]

@Da-Colon

First see the error on dev:

1. Connect any wallet via WalletConnect and disconnect.
2. Reopen Connect Modal and Select Wallet Connect again. Should do nothing.

This is not my experience on the dev site. I'm able to connect via WC, disconnect using the Fractal app, then immediately connect again with WC without a refresh.

[Da-Colon]

@adamgall hmmm you are right, I'm not able to reproduce on dev...weird. it was very consistent and was easy to reproduce yesterday

[Da-Colon]

Closing PR for now, currently not able to reproduce on dev. Will keep an eye out if it becomes an issue