Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove infura rpc api key #1391

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Remove infura rpc api key #1391

merged 4 commits into from
Feb 29, 2024

Conversation

adamgall
Copy link
Member

@adamgall adamgall commented Feb 29, 2024 •
edited
Loading

Removes yet another API key in an environment variable!

These days it's possible to use wagmi's public client as an EIP 1193 provider within the evm-proxy-detection library.

Testing

  1. Open up a DAO
  2. Go to the Template Creation page, start a new template
  3. Paste in a proxy address into the target address field
  4. Notice how the underlying implementation's functions show up in the function selector!

@adamgall adamgall requested review from mudrila and Da-Colon February 29, 2024 02:04
@adamgall adamgall self-assigned this Feb 29, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 29, 2024 •
edited
Loading

✅ Deploy Preview for fractal-framework-dev ready!

Name Link
🔨 Latest commit ca80672
🔍 Latest deploy log https://app.netlify.com/sites/fractal-framework-dev/deploys/65dfe619366b620008590c09
😎 Deploy Preview https://deploy-preview-1391.app.dev.fractalframework.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adamgall adamgall merged commit 56a3711 into develop Feb 29, 2024
5 checks passed
@adamgall adamgall deleted the remove-infura-rpc-api-key branch February 29, 2024 13:47
@adamgall adamgall mentioned this pull request Mar 1, 2024
Merged
@adamgall adamgall added the maintenance Keep the lights on label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Da-Colon Da-Colon Da-Colon approved these changes

@mudrila mudrila mudrila approved these changes

Assignees

@adamgall adamgall

Labels
maintenance Keep the lights on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamgall @mudrila @Da-Colon