-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align deployment of Safe to be of same version as Safe UI-deployed and having fallback handler attached #1375
Align deployment of Safe to be of same version as Safe UI-deployed and having fallback handler attached #1375
Conversation
✅ Deploy Preview for fractal-framework-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprised we still have to rely on the typechain files for these. But tested and it indeed works. I see that the Contract+L2 is correctly displayed in the settings and the CompatibilityFallbackHandler has been set up as a module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whenever using the safe-deployments
package to get
singleton addresses, the filter simply confirms that the contract has been deployed on the given network.
It's still up to the caller to dig into the networkAddresses
object of the result to find the official address for a given chain, do not rely on the defaultAddress
!
This applies to the new CompatibilityFallbackHandler
code (which seems good for Sepolia and Polygon, but might as well do it for Mainnet too), as well as the actual Master Safe Singleton deployment address as well (for ALL THREE networks).
…t it retrieved from networkAddresses and not defaultAddress
Pretty lucky that we had those |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR swaps all the
GnosisSafe
usages toGnosisSafeL2
and addsfallbackHandler
to the create Safe flow, right intosetup
function call.Notes
Issue
Closes #1361
Testing
1.3.0+L2
) and attached Fallback Handler (could be found under "Modules" tab) also should be exactly the same. See screenshots below for references on how it should look likeScreenshots (if applicable)