Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move providers out of App directory #1370

Merged
merged 1 commit into from
Feb 21, 2024
Merged

move providers out of App directory #1370

merged 1 commit into from
Feb 21, 2024

Conversation

Da-Colon
Copy link
Contributor

Description

Notes

Issue / Notion doc (if applicable)

Testing

Screenshots (if applicable)

Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for fractal-framework-interface-dev ready!

Name Link
🔨 Latest commit 19fced9
🔍 Latest deploy log https://app.netlify.com/sites/fractal-framework-interface-dev/deploys/65d610ee1c51330008f3cb33
😎 Deploy Preview https://deploy-preview-1370--fractal-framework-interface-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@adamgall adamgall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frame in Chrome

  • Able to vote on existing proposals.
  • Unable to create new proposal. Clicking the "Create Proposal" button doesn't work. Examining logs reveals that it's an RPC provider "issue":
    • When my RPC provider is the default provider that Frame ships with (Pylon -- I'm not sure what that is), the error in console is:
      {
          "message": "Method eth_getLogs is not supported",
          "code": -32601
      }
      
    • When my RPC provider is PublicNode (https://ethereum-sepolia.publicnode.com), the error in console is:
      {
          "message": "exceed maximum block range: 50000",
          "code": -32701
      }
      

Metamask in Firefox

  • Able to create new proposals.
  • Able to vote on proposals.

I'm not going to explicitly "approve" this PR yet, given the issues I'm still seeing with creating proposals using Frame.

Copy link
Member

@adamgall adamgall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding an approval, along with referencing a new issue that will be worked on soon: #1371

@adamgall adamgall merged commit 78c934a into develop Feb 21, 2024
5 of 6 checks passed
@adamgall adamgall deleted the moving-providers branch February 21, 2024 20:42
@adamgall adamgall added the maintenance Keep the lights on label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Keep the lights on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants