[Production] Swap asSigner for asProvider to enforce Fractal's provider usage, logical fixes for proposal data encoding, tests #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduction of unit test suite
…of the usages of asSigner contract reads whenever applicable
…asProvider-whenever-possible Swap asSigner to asProvider in most cases to guarantee data reads from Fractal's provider
…-parameter Bugfix/encoded bool function parameter
✅ Deploy Preview for fractal-framework-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for fractal-framework-interface ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamgall
approved these changes
Feb 12, 2024
…ider-swap-to-as-signer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notes
Issue / Notion doc (if applicable)
Testing
Screenshots (if applicable)