Introduction of unit test suite #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fractal-framework-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mudrila
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces unit tests to the project, using
vitest(a recommended unit testing framework by Next.js).Notes
This PR is the result of a production but that Shutter encountered, in which they crafted a proposal which included transactions that took
boolvalues -- notably ones that should be "false" -- and our UI created encoded transaction data which included thoseboolvalues as "true" (0000000000000000000000000000000000000000000000000000000000000001), not "false (0000000000000000000000000000000000000000000000000000000000000000).Issue / Notion doc (if applicable)
n/a
Testing
All tests in this PR should pass.
There is one test which is commented out, because it will fail right now. This commented out test is the reason for this PR in the first place -- we have a bug in our function encoding code (
./src/utils/crypto.ts) that turns the function parameter string"false"into an encoded value oftrue.@mudrila after you implement a fix to the
encodeFunctionfunction in./src/utils/crypto.tsin a later PR, you should please un-comment this remaining test and it should pass.Screenshots (if applicable)
n/a