Fix quorum formatting #1348
Fix quorum formatting #1348
Conversation
…ng Safe deployment, adjust quorum displaying accordingly
✅ Deploy Preview for fractal-framework-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| const quorumPercentage = quorumNumerator.mul(100).div(quorumDenominator); |
| (this.daoData as AzoriusERC20DAO | AzoriusERC721DAO).votingStrategyType === | ||
| VotingStrategyType.LINEAR_ERC20 | ||
| ) { | ||
| const azoriusDAOData = this.daoData as AzoriusERC20DAO; |
There was a problem hiding this comment.
@mudrila can you explain these few lines a bit more?
There was a problem hiding this comment.
So the parentAllocationAmount exists only for AzoriusERC20DAO, only then we need to call setEncodedSetupTokenClaimData and setPredictedTokenClaimAddress - this const azoriusDAOData = this.daoData as AzoriusERC20DAO; performed solely for type constraints.
This is mostly copy-paste of lines removed from constructor but before it was daoData = daoData as AzoriusERC20DAO and we just don't need (and actually can't ahah) to reassign to this.daoData
And if you're talking about async init - that's to fetch QUORUM_DENOMINATOR on chain, we need to await for RPC request promise.
|
@mudrila you may merge at your convenience |
Description
Multiply quorum percentage by 10000 to get it into proper format during Safe deployment, adjust quorum displaying accordingly
Notes
Issue / Notion doc (if applicable)
Closes #1347
Testing
Screenshots (if applicable)