Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix casting snapshot vote on testnet #1320

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Fix casting snapshot vote on testnet #1320

merged 1 commit into from
Jan 16, 2024

Conversation

mudrila
Copy link
Contributor

@mudrila mudrila commented Jan 16, 2024

Description

This PR fixes casting vote on testnet

Notes

Actual issue was that Snapshot uses different hub URL for testnet than it has in their docs

Issue / Notion doc (if applicable)

Testing

  1. Create Safe with test snapshot URL
  2. Create proposal with weighted voting
  3. Vote on the proposal from Fractal
  4. Make sure vote passed, selected weights are properly reflected
  5. Verify through Snapshot UI that your vote displayed correctly

Screenshots (if applicable)

@mudrila mudrila added the bug Something isn't working label Jan 16, 2024
@mudrila mudrila requested review from adamgall and Da-Colon January 16, 2024 00:34
@mudrila mudrila self-assigned this Jan 16, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 16, 2024 •
edited
Loading

✅ Deploy Preview for fractal-framework-interface-dev ready!

Name Link
🔨 Latest commit 152e2ac
🔍 Latest deploy log https://app.netlify.com/sites/fractal-framework-interface-dev/deploys/65a5cf035ffdb3000823b8ff
😎 Deploy Preview https://deploy-preview-1320--fractal-framework-interface-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mudrila mudrila merged commit 3cece78 into develop Jan 16, 2024
5 checks passed
@mudrila mudrila deleted the fix/cast-snapshot-vote-on-testnet branch January 16, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgall adamgall Awaiting requested review from adamgall

@Da-Colon Da-Colon Awaiting requested review from Da-Colon

Assignees

@mudrila mudrila

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mudrila