Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Next.js link to prevent page reload while safe being reloaded #1319

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

mudrila
Copy link
Contributor

@mudrila mudrila commented Jan 5, 2024

Description

This PR fixes page reload when navigating between child/parent safe in hierarchy and to safe from search

Notes

It brings another issue, that "Invalid Safe" component flashes for a moment but then immediately proper Safe dashboard shown.

Issue / Notion doc (if applicable)

Testing

  1. Navigate to Safe that has at least one sub-Safe
  2. Go to the Safe's hierarchy page
  3. Click on the sub-Safe card
  4. Verify that page is not reloading but just navigates to the proper Safe's Dashboard
  5. It is expected that you might see "Invalid Safe" component flashing, but it should be immediately replaced with proper Safe details

Screenshots (if applicable)

@mudrila mudrila added the bug Something isn't working label Jan 5, 2024
@mudrila mudrila requested review from adamgall and Da-Colon January 5, 2024 19:52
@mudrila mudrila self-assigned this Jan 5, 2024
Copy link

netlify bot commented Jan 5, 2024

Deploy Preview for fractal-framework-interface-dev ready!

Name Link
🔨 Latest commit a138a79
🔍 Latest deploy log https://app.netlify.com/sites/fractal-framework-interface-dev/deploys/65985debbfc8df00083e8b86
😎 Deploy Preview https://deploy-preview-1319--fractal-framework-interface-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mudrila mudrila merged commit 3afed3c into develop Jan 11, 2024
5 checks passed
@mudrila mudrila deleted the fix/prevent-page-reload-while-fetching-safe branch January 11, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant