Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA bug fixes #1315

Merged
merged 6 commits into from
Jan 5, 2024
Merged

QA bug fixes #1315

merged 6 commits into from
Jan 5, 2024

Conversation

mudrila
Copy link
Contributor

@mudrila mudrila commented Dec 19, 2023

Description

This PR fixes several QA bug fixes

Notes

Also contains implementation for supporting testnet Snapshot spaces

Issue / Notion doc (if applicable)

Closes #1307
Closes #1308
Closes #1309
Closes #1310
Closes #1311

Testing

Screenshots (if applicable)

…successful, change Snapshot link from rendering button to rendering <a>, change proposal Details link from rendering button to rendering <a>
@mudrila mudrila added the bug Something isn't working label Dec 19, 2023
@mudrila mudrila self-assigned this Dec 19, 2023
Copy link

netlify bot commented Dec 19, 2023

Deploy Preview for fractal-framework-interface-dev ready!

Name Link
🔨 Latest commit 9944749
🔍 Latest deploy log https://app.netlify.com/sites/fractal-framework-interface-dev/deploys/6581dc7118c3a200085ef048
😎 Deploy Preview https://deploy-preview-1315--fractal-framework-interface-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Da-Colon
Copy link
Contributor

Da-Colon commented Jan 4, 2024

Still something going on with:
(ERC20-DAO): Vote breakdown doesn't update.

image

All the other Closed issues seem to be fixed

@Da-Colon Da-Colon requested review from Da-Colon and removed request for sethhrbek January 4, 2024 20:45
@mudrila
Copy link
Contributor Author

mudrila commented Jan 5, 2024

Still something going on with: (ERC20-DAO): Vote breakdown doesn't update.

image

All the other Closed issues seem to be fixed

It seems like you voted with 0 votes, which eventually doesn't change total number of casted votes. That's a known issue, we should be blocking user from voting if he has 0 voting power

@mudrila mudrila merged commit 700979e into develop Jan 5, 2024
5 checks passed
@mudrila mudrila deleted the fix/qa-bug-fixes branch January 5, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants