Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e test for snapshot proposals #1289

Closed
wants to merge 2 commits into from
Closed

Conversation

mudrila
Copy link
Contributor

@mudrila mudrila commented Oct 26, 2023

Description

This PR implements e2e tests for viewing Snapshot proposals

Notes

We're using ETHLizzards as testing reference to avoid creating Snapshot space through their API.

Issue / Notion doc (if applicable)

Closes #1288

Testing

  1. Run tests
  2. Verify they all passing

Screenshots (if applicable)

@mudrila mudrila added the enhancement New feature or request label Oct 26, 2023
@mudrila mudrila requested a review from adamgall October 26, 2023 16:37
@mudrila mudrila self-assigned this Oct 26, 2023
@netlify
Copy link

netlify bot commented Oct 26, 2023

Deploy Preview for fractal-framework-interface-dev ready!

Name Link
🔨 Latest commit 2119b26
🔍 Latest deploy log https://app.netlify.com/sites/fractal-framework-interface-dev/deploys/653ad685aac8cf00082b0a44
😎 Deploy Preview https://deploy-preview-1289--fractal-framework-interface-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adamgall
Copy link
Member

Hi @mudrila,

When I run npm run tests after getting the docker containers running, I receive lots of errors in the test (not all though). Is there something else I should be doing?

@mudrila
Copy link
Contributor Author

mudrila commented Oct 31, 2023

Hi @mudrila,

When I run npm run tests after getting the docker containers running, I receive lots of errors in the test (not all though). Is there something else I should be doing?

@adamgall yeah, tests are also failing on CI, I'm trying to figure out why. It feels like it just takes too long sometimes to navigate to DAO dashboard, thus tests are failing. It's also quite unstable on my machine, but I was able to run it with green checkmarks
I'll ping you once it is fixed

@sethhrbek
Copy link
Contributor

Will revisit later

@sethhrbek sethhrbek closed this Dec 12, 2023
@mudrila mudrila deleted the feature/snapshot-e2e-testing branch August 15, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snapshot e2e tests
3 participants