Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor useDaoName #1531

Closed
DarksightKellar opened this issue Apr 10, 2024 · 0 comments · Fixed by #1918
Closed

Refactor useDaoName #1531

DarksightKellar opened this issue Apr 10, 2024 · 0 comments · Fixed by #1918
Assignees
@adamgall
Labels
maintenance Keep the lights on

Comments

@DarksightKellar
Copy link
Contributor

DarksightKellar commented Apr 10, 2024 •
edited by adamgall
Loading

The file useDaoName.ts currently has 2 hooks: useDAOName and useLazyDAOName, which both do very similar things. We should consider merging these two into one, and making sure any unused code paths are removed.

Context: this PR comment

There's also a bug related to this where Safe Names that are loading in, don't show the "Loading Safe" message, just an empty string.
@DarksightKellar DarksightKellar converted this from a draft issue Apr 10, 2024
@DarksightKellar DarksightKellar added the maintenance Keep the lights on label Apr 10, 2024
@DarksightKellar DarksightKellar changed the title Refactor useDaoName Refactor useDaoName Apr 10, 2024
@DarksightKellar DarksightKellar mentioned this issue Apr 11, 2024
Merged
@adamgall adamgall moved this to Ready in Decent May 22, 2024
@adamgall adamgall moved this from Ready to In progress in Decent May 24, 2024
@adamgall adamgall self-assigned this May 24, 2024
@adamgall adamgall moved this from In progress to In review in Decent May 24, 2024
@adamgall adamgall mentioned this issue May 24, 2024
Merged
@github-project-automation github-project-automation bot moved this from In review to Done in Decent May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamgall adamgall

Labels
maintenance Keep the lights on
Projects
Decent
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show loading message when My Safe names are loading decentdao/decent-interface
2 participants
@adamgall @DarksightKellar