Fix dom node nesting, remove wagmi public provider, fix conditional t…

…o prevent setting ERC20 claim contract
decentdao · Jan 24, 2024 · e8dde06 · e8dde06
1 parent 6fcd73f
commit e8dde06
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 19 deletions.
diff --git a/src/components/Proposals/ProposalActions/ProposalAction.tsx b/src/components/Proposals/ProposalActions/ProposalAction.tsx
@@ -103,17 +103,13 @@ export function ProposalAction({
   if (!showActionButton) {
     if (!expandedView) {
       return (
-        <Link
+        <Button
+          as={Link}
           href={DAO_ROUTES.proposal.relative(daoAddress, proposal.proposalId)}
-          passHref
+          variant="secondary"
         >
-          <Button
-            as="a"
-            variant="secondary"
-          >
-            {t('details')}
-          </Button>
-        </Link>
+          {t('details')}
+        </Button>
       );
     }
     // This means that Proposal in state where there's no action to perform

diff --git a/src/components/ui/menus/AccountDisplay/MenuItemNetwork.tsx b/src/components/ui/menus/AccountDisplay/MenuItemNetwork.tsx
@@ -52,13 +52,7 @@ export function MenuItemNetwork() {
               key={chain.chainId}
               value={chain.chainId}
             >
-              <Box
-                w="1rem"
-                h="1rem"
-                bg={chain.color}
-                rounded="full"
-              />
-              <Text textStyle="text-base-mono-medium">{chain.name}</Text>
+              {chain.name}
             </option>
           ))}
         </Select>

diff --git a/src/hooks/DAO/loaders/governance/useERC20Claim.ts b/src/hooks/DAO/loaders/governance/useERC20Claim.ts
@@ -26,7 +26,8 @@ export function useERC20Claim() {
     const tokenClaimArray = await possibleTokenClaimContract
       .queryFilter(tokenClaimFilter)
       .catch(() => []);
-    if (!tokenClaimArray.length && tokenClaimArray[0].args[1] === tokenContract.asSigner.address) {
+
+    if (!tokenClaimArray.length || tokenClaimArray[0].args[1] === tokenContract.asSigner.address) {
       return;
     }
     // action to governance

diff --git a/src/providers/NetworkConfig/rainbow-kit.config.ts b/src/providers/NetworkConfig/rainbow-kit.config.ts
@@ -10,7 +10,6 @@ import {
 import { Chain, configureChains, createClient, createStorage, mainnet } from 'wagmi';
 import { hardhat } from 'wagmi/chains';
 import { jsonRpcProvider } from 'wagmi/providers/jsonRpc';
-import { publicProvider } from 'wagmi/providers/public';
 import { APP_NAME } from '../../constants/common';
 import { supportedChains } from './NetworkConfigProvider';
 import { testWallet } from './testWallet';
@@ -31,7 +30,6 @@ export const { chains, provider } = configureChains(supportedWagmiChains, [
       return { http: `https://${networkUrl}`, webSocket: `wss://${networkUrl}` };
     },
   }),
-  publicProvider(),
 ]);
 
 const defaultWallets = [