Explicitly set bigNumberValue to null while creating proposal templat…

…e and within BigNumberInput
decentdao · Apr 8, 2024 · ac192ff · ac192ff
1 parent 6b0aade
commit ac192ff
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/src/components/CreateProposalTemplate/constants.ts b/src/components/CreateProposalTemplate/constants.ts
@@ -2,7 +2,7 @@ import { CreateProposalTemplateTransaction } from '../../types/createProposalTem
 
 export const DEFAULT_PROPOSAL_TEMPLATE_TRANSACTION: CreateProposalTemplateTransaction = {
   targetAddress: '',
-  ethValue: { value: '', bigNumberValue: undefined },
+  ethValue: { value: '', bigNumberValue: null },
   functionName: '',
   parameters: [
     {

diff --git a/src/components/DaoCreator/formComponents/AzoriusTokenAllocation.tsx b/src/components/DaoCreator/formComponents/AzoriusTokenAllocation.tsx
@@ -11,7 +11,7 @@ interface ITokenAllocations {
   setFieldValue: (field: string, value: any) => void;
   addressErrorMessage: string | null;
   amountErrorMessage: string | null;
-  amountInputValue: BigNumber | undefined;
+  amountInputValue: BigNumber | undefined | null;
   allocationLength: number;
 }
 

diff --git a/src/components/ui/forms/BigNumberInput.tsx b/src/components/ui/forms/BigNumberInput.tsx
@@ -13,12 +13,12 @@ import { BigNumberValuePair } from '../../../types';
 export interface BigNumberInputProps
   extends Omit<InputElementProps, 'value' | 'onChange'>,
     FormControlOptions {
-  value: BigNumber | undefined;
+  value: BigNumber | undefined | null;
   onChange: (value: BigNumberValuePair) => void;
   decimalPlaces?: number;
   min?: string;
   max?: string;
-  maxValue?: BigNumber;
+  maxValue?: BigNumber | null;
 }
 /**
  * This component will add a chakra Input component that accepts and sets a BigNumber
@@ -82,7 +82,7 @@ export function BigNumberInput({
       if (stringValue === '') {
         onChange({
           value: stringValue,
-          bigNumberValue: undefined,
+          bigNumberValue: null,
         });
         setInputValue('');
         return;

diff --git a/src/hooks/utils/useApproval.tsx b/src/hooks/utils/useApproval.tsx
@@ -8,7 +8,7 @@ import { useTransaction } from './useTransaction';
 const useApproval = (
   tokenContract?: VotesERC20 | VotesERC20Wrapper,
   spenderAddress?: string,
-  userBalance?: BigNumber,
+  userBalance?: BigNumber | null,
 ) => {
   const { address: account } = useAccount();
   const [allowance, setAllowance] = useState(BigNumber.from(0));

diff --git a/src/types/common.ts b/src/types/common.ts
@@ -2,7 +2,7 @@ import { BigNumber } from 'ethers';
 
 export interface BigNumberValuePair {
   value: string;
-  bigNumberValue?: BigNumber;
+  bigNumberValue?: BigNumber | null;
 }
 
 export type WithError = { error?: string };