Show cached prices on FE if request to CoinGecko failed

decentdao · Mar 6, 2024 · a3783d4 · a3783d4
1 parent 8633535
commit a3783d4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/components/pages/DAOTreasury/hooks/useFormatCoins.tsx b/src/components/pages/DAOTreasury/hooks/useFormatCoins.tsx
@@ -32,9 +32,11 @@ export function useFormatCoins(assets: SafeBalanceUsdResponse[]) {
       for (let i = 0; i < assets.length; i++) {
         let asset = assets[i];
         if (asset.balance === '0') continue;
-        const tokenPrice = asset.tokenAddress
-          ? tokenPrices[asset.tokenAddress.toLowerCase()]
-          : tokenPrices.ethereum;
+        const tokenPrice = tokenPrices
+          ? asset.tokenAddress
+            ? tokenPrices[asset.tokenAddress.toLowerCase()]
+            : tokenPrices.ethereum
+          : 0;
 
         let tokenFiatBalance = 0;
         if (tokenPrice && asset.balance) {

diff --git a/src/providers/App/hooks/usePriceAPI.ts b/src/providers/App/hooks/usePriceAPI.ts
@@ -32,6 +32,10 @@ export default function usePriceAPI() {
         if (pricesResponseBody.error) {
           // We don't need to log error here as it is supposed to be logged through Netlify function anyway
           toast.warning(t('tokenPriceFetchingError'));
+          if (pricesResponseBody.data) {
+            // Netlify function might fail due to rate limit of CoinGecko error, but it still will return cached prices.
+            return pricesResponseBody.data;
+          }
         } else {
           return pricesResponseBody.data;
         }