Add comment describing placement of ModalProvider, better typing for …

…Textarea resize prop
decentdao · Mar 18, 2024 · 49c1423 · 49c1423
1 parent e695b8a
commit 49c1423
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/components/ui/forms/InputComponent.tsx b/src/components/ui/forms/InputComponent.tsx
@@ -44,7 +44,7 @@ interface TextareaProps extends Omit<BaseProps, 'children'> {
   onChange: React.ChangeEventHandler<HTMLTextAreaElement> | undefined;
   placeholder?: string;
   rows?: number;
-  resize?: ResponsiveValue<string>;
+  resize?: ResponsiveValue<'vertical' | 'horizontal' | 'both' | 'none'>;
 }
 interface BigNumberProps
   extends Omit<BaseProps, 'children' | 'value'>,
@@ -161,7 +161,7 @@ export function TextareaComponent(props: TextareaProps) {
     >
       <Textarea
         id={id}
-        resize={resize as any}
+        resize={resize}
         onChange={onChange}
         value={value}
         isDisabled={disabled}

diff --git a/src/router.tsx b/src/router.tsx
@@ -21,6 +21,9 @@ export const router = createBrowserRouter([
   {
     path: '/',
     element: (
+      // We're placing ModalProvider here instead of src/providers/Providers.tsx due to the need of having router context
+      // within underlying modals. Otherwise - trying to invoke routing-related hooks would lead to crash.
+      // Not the best place to have this provider here but also more reasonalbe than putting that into <Layout />
       <ModalProvider>
         <Layout />
       </ModalProvider>