Don't cache things when doing ENS name network lookups, let wagmi/vie…

…m handle caching
decentdao · May 1, 2024 · 46b0c42 · 46b0c42
1 parent e300a1f
commit 46b0c42
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 31 deletions.
diff --git a/src/hooks/utils/cache/cacheDefaults.ts b/src/hooks/utils/cache/cacheDefaults.ts
@@ -24,7 +24,6 @@ export enum CacheExpiry {
  */
 export enum CacheKeys {
   FAVORITES = 'favorites',
-  ENS_RESOLVE_PREFIX = 'ens_resolve_', // name.eth -> 0x0 caching
   DECODED_TRANSACTION_PREFIX = 'decode_trans_',
   MULTISIG_METADATA_PREFIX = 'm_m_',
   MASTER_COPY_PREFIX = 'master_copy_of_',

diff --git a/src/hooks/utils/useAddress.ts b/src/hooks/utils/useAddress.ts
@@ -1,19 +1,14 @@
 import { useEffect, useState } from 'react';
 import { getAddress, isAddress } from 'viem';
 import { useEthersProvider } from '../../providers/Ethers/hooks/useEthersProvider';
-import { useNetworkConfig } from '../../providers/NetworkConfig/NetworkConfigProvider';
 import { couldBeENS } from '../../utils/url';
-import { CacheKeys, CacheExpiry } from './cache/cacheDefaults';
-import { useLocalStorage } from './cache/useLocalStorage';
 
 const useAddress = (addressInput: string | undefined) => {
   const provider = useEthersProvider();
 
   const [address, setAddress] = useState<string>();
   const [isValidAddress, setIsValidAddress] = useState<boolean>();
   const [isAddressLoading, setIsAddressLoading] = useState<boolean>(false);
-  const { setValue, getValue } = useLocalStorage();
-  const { chain } = useNetworkConfig();
 
   useEffect(() => {
     setIsAddressLoading(true);
@@ -49,21 +44,6 @@ const useAddress = (addressInput: string | undefined) => {
       return;
     }
 
-    // check our cache for a potential resolved address (name.eth -> 0x0)
-    const cachedResolvedAddress = getValue(addressInput);
-    if (cachedResolvedAddress) {
-      setAddress(cachedResolvedAddress);
-      setIsValidAddress(true);
-      setIsAddressLoading(false);
-      return;
-    } else if (cachedResolvedAddress === undefined) {
-      // a previous lookup did not resolve
-      setAddress(addressInput);
-      setIsValidAddress(false);
-      setIsAddressLoading(false);
-      return;
-    }
-
     if (!provider) {
       setAddress(addressInput);
       setIsValidAddress(undefined);
@@ -73,19 +53,11 @@ const useAddress = (addressInput: string | undefined) => {
 
     provider
       .resolveName(addressInput)
-      .then((resolvedAddress: any) => {
+      .then(resolvedAddress => {
         if (!resolvedAddress) {
-          // cache an unresolved address as 'undefined' for 20 minutes
-          setValue(CacheKeys.ENS_RESOLVE_PREFIX + addressInput, undefined, 20);
           setAddress(addressInput);
           setIsValidAddress(false);
         } else {
-          // cache a resolved address for a week
-          setValue(
-            CacheKeys.ENS_RESOLVE_PREFIX + addressInput,
-            resolvedAddress,
-            CacheExpiry.ONE_WEEK,
-          );
           setAddress(resolvedAddress);
           setIsValidAddress(true);
         }
@@ -97,7 +69,7 @@ const useAddress = (addressInput: string | undefined) => {
       .finally(() => {
         setIsAddressLoading(false);
       });
-  }, [provider, addressInput, getValue, setValue, chain]);
+  }, [addressInput, provider]);
 
   return { address, isValidAddress, isAddressLoading };
 };