Mainnet polygon deployment cleanup #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng deployment script.
adamgall
force-pushed
the
mainnet-polygon-deployment-cleanup
branch
from
55e8565 to
c325da7
Compare
…mainnet and polygon
adamgall
force-pushed
the
mainnet-polygon-deployment-cleanup
branch
from
c325da7 to
09a8d74
Compare
adamgall
added a commit
that referenced
this pull request
Jul 6, 2024
* No more deploying LinearERC20Voting on mainnet and polygon when running deployment script. * Include the original LinearERC20Voting contract which is deployed to mainnet and polygon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timeline of events:
LinearERC20Votingis deployed to Mainnet and Polygon.LinearERC20Voting.solsource file.LinearERC20Votingis deployed to all the other chains.What this means, is that when running the deployment system against mainnet or polygon, it will deploy
LinearERC20Voting(andLinearERC20WrappedVotingwhich inherits), due to that small difference, the system is technically correct that this version of the contract doesn't exist on that chain and so it should be deployed.I just added some early exits to the deployment script, to skip these contracts on mainnet and polygon. I've also added the original contract for posterity.
It would be nice to just deploy the updated version to mainnet and polygon and publish these new master copy addresses, but I think there will be some bad bugs in the frontend if we did that.
AFAIK we're stuck with our current implementation address, at least until we build some more concepts of versioning the master copy contracts into our systems here.