Require that DecentAutonomousAdmin (current and future versions) impl…

…ement a `version` function
decentdao · Nov 1, 2024 · 1836224 · 1836224
1 parent 11b0c90
commit 1836224
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 1 deletion.
diff --git a/contracts/autonomous-admin/DecentAutonomousAdminV1.sol b/contracts/autonomous-admin/DecentAutonomousAdminV1.sol
@@ -20,6 +20,10 @@ contract DecentAutonomousAdminV1 is
     // //////////////////////////////////////////////////////////////
     //                         Public Functions
     // //////////////////////////////////////////////////////////////
+    function version() external pure override returns (uint32) {
+        return 1;
+    }
+
     function triggerStartNextTerm(TriggerStartArgs calldata args) public {
         IHatsElectionsEligibility hatsElectionModule = IHatsElectionsEligibility(
                 args.hatsProtocol.getHatEligibilityModule(args.hatId)

diff --git a/contracts/interfaces/autonomous-admin/IDecentAutonomousAdmin.sol b/contracts/interfaces/autonomous-admin/IDecentAutonomousAdmin.sol
@@ -0,0 +1,6 @@
+// SPDX-License-Identifier: MIT
+pragma solidity 0.8.28;
+
+interface IDecentAutonomousAdmin {
+    function version() external view returns (uint32);
+}
diff --git a/contracts/interfaces/autonomous-admin/IDecentAutonomousAdminV1.sol b/contracts/interfaces/autonomous-admin/IDecentAutonomousAdminV1.sol
@@ -1,10 +1,12 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.28;
 
+import {IDecentAutonomousAdmin} from "./IDecentAutonomousAdmin.sol";
 import {IHats} from "../hats/IHats.sol";
 
-interface IDecentAutonomousAdminV1 {
+interface IDecentAutonomousAdminV1 is IDecentAutonomousAdmin {
     error NotCurrentWearer();
+
     struct TriggerStartArgs {
         address currentWearer;
         IHats hatsProtocol;

diff --git a/test/autonomous-admin/DecentAutonomousAdminV1.test.ts b/test/autonomous-admin/DecentAutonomousAdminV1.test.ts
@@ -93,6 +93,12 @@ describe('DecentAutonomousAdminHatV1', function () {
     await hatsElectionModule.elect(nextTermEnd, [await secondWearer.getAddress()]);
   });
 
+  describe('version', function () {
+    it('should return the correct version', async () => {
+      expect(await decentAutonomousAdminInstance.version()).to.equal(1);
+    });
+  });
+
   describe('triggerStartNextTerm', function () {
     describe('before the first term is over', function () {
       it('should have correct wearers', async () => {