-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add oleobj arg to just find external relations #772
base: master
Are you sure you want to change the base?
Add oleobj arg to just find external relations #772
Commits on Nov 28, 2022
-
Fix occurrence of "msodde" in io-encoding license text
(...and one typo in doc string)
Configuration menu - View commit details
-
Copy full SHA for 4610c02 - Browse repository at this point
Copy the full SHA 4610c02View commit details -
Not needed any more when using log_helper
Configuration menu - View commit details
-
Copy full SHA for 8764504 - Browse repository at this point
Copy the full SHA 8764504View commit details -
People (like me) might think that when they give "-r" as argument they could give a directory with samples as input, e.g. oleobj -r /path/to/samples when actually they need to specify that with a glob and -r is independent of that oleobj /path/to/samples\* Clarify that in the help-string of "-r". Also, giving a glob did result in an error saying that this is not an existing file. Fixed that.
Configuration menu - View commit details
-
Copy full SHA for e15bb61 - Browse repository at this point
Copy the full SHA e15bb61View commit details -
Configuration menu - View commit details
-
Copy full SHA for f00197e - Browse repository at this point
Copy the full SHA f00197eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9443f08 - Browse repository at this point
Copy the full SHA 9443f08View commit details -
Should not matter but this is safer and consistent with other tests.
Configuration menu - View commit details
-
Copy full SHA for fe5517f - Browse repository at this point
Copy the full SHA fe5517fView commit details -
tests: Add helper to temporarily extract malware samples
When testing json-output we need to run samples through the "main" functions of modules, not just their "process_file" functions that would accept the extracted and decrypted data from the existing helper function "loop_over_files". They need a filename as input, so add helper to create a temp dir and extract&decrypt samples to that temporarily.
Configuration menu - View commit details
-
Copy full SHA for fd96cfe - Browse repository at this point
Copy the full SHA fd96cfeView commit details -
tests: Add test for json output
Since this test runs 3 scripts over all samples it takes pretty long. Therefore, disable it per default, enable with a environment variable OLETOOLS_TEST_JSON=1 Also, decrypting and extracting malware samples onto the disc might cause trouble, another reason for not enabling this test per default.
Configuration menu - View commit details
-
Copy full SHA for 138f8c0 - Browse repository at this point
Copy the full SHA 138f8c0View commit details -
oleobj also serves as finder for external relationships. If users want just that behaviour and no dumping of embedded objects, give them the option to get that. Also clarify this double-purpose in the doc string. There is a TODO that might be aimed for exactly that, but I am uncertain whether I interpret it correctly
Configuration menu - View commit details
-
Copy full SHA for 1f537b8 - Browse repository at this point
Copy the full SHA 1f537b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for c37d8a2 - Browse repository at this point
Copy the full SHA c37d8a2View commit details -
tests: Check that oleobj reports finding external relationships
Do not just rely on return value. Also avoid dumping stuff when just checking links.
Configuration menu - View commit details
-
Copy full SHA for 3a896dd - Browse repository at this point
Copy the full SHA 3a896ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c66f26 - Browse repository at this point
Copy the full SHA 5c66f26View commit details -
oleobj: Add return-val for "found external relationship"
Do not abuse the "did dump"-flag for "did find external relationship", add an extra flag and return value for that
Configuration menu - View commit details
-
Copy full SHA for 8bf957f - Browse repository at this point
Copy the full SHA 8bf957fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d441a5 - Browse repository at this point
Copy the full SHA 3d441a5View commit details -
tests: Remove old hack we do not need any more
Branch that fixed this has been merged Oct 2019.
Configuration menu - View commit details
-
Copy full SHA for 198b16c - Browse repository at this point
Copy the full SHA 198b16cView commit details