Flush TCP socket on exception #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
stefanb2
force-pushed
the
topic-flush-socket-on-exception
branch
from
d8a1b5a
to
2a5342a
Compare
Not all bytes may have been read from the TCP socket read buffer when the request processing is aborted by an exception. - remember the frame length from the message header - frame length must be at least 2 octets - decrease remaining length on every successful read - after sending the exception flush any remaining bytes from the socket Fixes debevv#67
stefanb2
force-pushed
the
topic-flush-socket-on-exception
branch
from
2a5342a
to
8d75d44
Compare
- don't write more data to socket than is left in buffer - add missing LF in client printf()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all bytes may have been read from the TCP socket read buffer when the request processing is aborted by an exception.
Fixes #67