Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(provider, analyser): support jd new bill format, Set plusaccount to methodaccount for refund records in jd bills #136

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix(provider, analyser): support jd new bill format, Set plusaccount to methodaccount for refund records in jd bills #136

wants to merge 4 commits into from
+430 −177

Conversation

zwyyy456
Copy link

Description

支持京东的新账单格式，对于京东的退款记录，plusAccount 设置为 methodAccount，miniusAccount 设置为 targetAccount。

@zwyyy456
fix(provider, analyser): support jd new bill format, Set `plusaccount…
77b028b 
…` to `methodaccount` for refund records in jd bills
@zwyyy456 zwyyy456 mentioned this pull request Dec 14, 2024
Open
@ramsayleung
Copy link
Contributor

感谢你的贡献, 可否再更新 README, 在已支持账单列表把JD 账单也加上?

gaocegege
gaocegege approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same request，可以加一下文档么

@zwyyy456 zwyyy456 requested a review from a team as a code owner December 19, 2024 02:24
@gaocegege
Copy link
Member

LGTM

Thanks for your contribution! 🎉 👍

@gaocegege
Copy link
Member

cc @ramsayleung

Triple-Z
Triple-Z reviewed Dec 19, 2024
View reviewed changes
Copy link
Member

@Triple-Z Triple-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

补充下 jd 新格式的测试用例？

@zwyyy456
Copy link
Author

ok，我下班后弄～

@gaocegege
Copy link
Member

Thanks!

@zwyyy456
test(jd): Update JD test cases and docs for new bill format
7492961 
Modified JD test cases to align with the new bill format. Updated the
corresponding config.yaml file and supplemented the documentation to
reflect these changes.
ramsayleung
ramsayleung reviewed Jan 1, 2025
View reviewed changes
README.md Outdated
@@ -871,6 +881,11 @@ BMO账单中的记账金额中存在收入/支出之分，通过这个机制就

### 京东

<details>
<summary>
BMO银行配置文件示例
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个应该是「京东」，而不是「BMO」?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改；

@ramsayleung
Copy link
Contributor

感谢, 新年快乐 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Triple-Z Triple-Z Triple-Z left review comments

@ramsayleung ramsayleung ramsayleung approved these changes

@gaocegege gaocegege gaocegege approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zwyyy456 @ramsayleung @gaocegege @Triple-Z